Skip to content

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Jun 24, 2025

Description

Builds off of #18159, contributes to #18187

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.0 milestone Jun 24, 2025
@neutrinoceros neutrinoceros added Release no-changelog-entry-needed Build all wheels Run all the wheel builds rather than just a selection github_actions Pull requests that update GitHub Actions code Python 3.14 labels Jun 24, 2025
Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros
Copy link
Contributor Author

I split out the fix to the test suite for windows+numpy 2.4 into its own PR: #18337

@neutrinoceros neutrinoceros force-pushed the whl/cp314-nightlies branch 3 times, most recently from ee9fe35 to efc487a Compare June 24, 2025 18:18
@neutrinoceros neutrinoceros force-pushed the whl/cp314-nightlies branch from efc487a to 21eaccb Compare July 2, 2025 19:43
@neutrinoceros
Copy link
Contributor Author

This should be ready to undraft now.

@neutrinoceros neutrinoceros marked this pull request as ready for review July 2, 2025 19:44
@pllim pllim requested a review from a team July 2, 2025 20:04
@neutrinoceros
Copy link
Contributor Author

Only 2 weeks to go before rc1, I think it'd be good to give it chance to downstream packages to check out this year's Python before then. Ping @astrofrog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build all wheels Run all the wheel builds rather than just a selection github_actions Pull requests that update GitHub Actions code no-changelog-entry-needed Python 3.14 Release testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant