-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MNT: bump ubuntu image (22.04
-> 24.04
) and uraimo/run-on-arch-action
(v2.8.1
-> v3.0.0
) on exotic archs
#17827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
👋 Thank you for your draft pull request! Do you know that you can use |
22.04
-> 24.04
) on exotic archs
Looks like the issue resolution I linked to wasn't enough. I honestly lost track of the exact stack of dependencies that were affected and it's not yet clear to me where the actual problem lives. Maybe I'll just keep this open for further experiments. update: maybe just follow |
uraimo is gonna do a major release soon, so maybe wait for that and then bump the workflow? |
yup, that seems to be the plan at the moment ! |
22.04
-> 24.04
) on exotic archs22.04
-> 24.04
) and uraimo/run-on-arch-action
(2.8.1
-> v3.0.0
) on exotic archs
22.04
-> 24.04
) and uraimo/run-on-arch-action
(2.8.1
-> v3.0.0
) on exotic archs22.04
-> 24.04
) and uraimo/run-on-arch-action
(v2.8.1
-> v3.0.0
) on exotic archs
Looking good so far, so I linked back the two issues this is supposed to fix. |
Great, it seems to have worked here - and I already went ahead and implemented it in my own package too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! The one CI failure is unrelated.
Should we just revert back to ubuntu-latest while we're at it? |
p.s. I am now officially annoyed by http://www.gnu.org/licenses/lgpl.html always blocking CI and failing link check. Why are we even linking to a license we're not using? That is issue for another day. |
In my opinion we're better off with explicit version pinning here, don't you think ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do it then. Thanks!
…) and `uraimo/run-on-arch-action` (`v2.8.1` -> `v3.0.0`) on exotic archs
…827-on-v7.0.x Backport PR #17827 on branch v7.0.x (MNT: bump ubuntu image (`22.04` -> `24.04`) and `uraimo/run-on-arch-action` (`v2.8.1` -> `v3.0.0`) on exotic archs)
Description
This reverts #17807 but still keeps the image pinned
xref: tonistiigi/binfmt#215 (comment)