Skip to content

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Feb 28, 2025

Description

This reverts #17807 but still keeps the image pinned
xref: tonistiigi/binfmt#215 (comment)

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@neutrinoceros neutrinoceros changed the title MNT: bump ubuntu image (22.04 -> 24.04) on exotic archs MNT: bump ubuntu image (22.04 -> 24.04) on exotic archs Feb 28, 2025
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Feb 28, 2025

Looks like the issue resolution I linked to wasn't enough. I honestly lost track of the exact stack of dependencies that were affected and it's not yet clear to me where the actual problem lives. Maybe I'll just keep this open for further experiments.

update: maybe just follow

@pllim
Copy link
Member

pllim commented Feb 28, 2025

uraimo is gonna do a major release soon, so maybe wait for that and then bump the workflow?

@neutrinoceros
Copy link
Contributor Author

yup, that seems to be the plan at the moment !

@neutrinoceros neutrinoceros changed the title MNT: bump ubuntu image (22.04 -> 24.04) on exotic archs MNT: bump ubuntu image (22.04 -> 24.04) and uraimo/run-on-arch-action (2.8.1 -> v3.0.0) on exotic archs Feb 28, 2025
@neutrinoceros neutrinoceros changed the title MNT: bump ubuntu image (22.04 -> 24.04) and uraimo/run-on-arch-action (2.8.1 -> v3.0.0) on exotic archs MNT: bump ubuntu image (22.04 -> 24.04) and uraimo/run-on-arch-action (v2.8.1 -> v3.0.0) on exotic archs Feb 28, 2025
@neutrinoceros
Copy link
Contributor Author

Looking good so far, so I linked back the two issues this is supposed to fix.
I will undraft this later if affected jobs complete successfully (or, if they fail with clearly different failure modes) !

@neutrinoceros neutrinoceros marked this pull request as ready for review February 28, 2025 18:24
@mhvk
Copy link
Contributor

mhvk commented Feb 28, 2025

Great, it seems to have worked here - and I already went ahead and implemented it in my own package too.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! The one CI failure is unrelated.

@pllim
Copy link
Member

pllim commented Feb 28, 2025

Should we just revert back to ubuntu-latest while we're at it?

@pllim
Copy link
Member

pllim commented Feb 28, 2025

p.s. I am now officially annoyed by http://www.gnu.org/licenses/lgpl.html always blocking CI and failing link check. Why are we even linking to a license we're not using? That is issue for another day.

@neutrinoceros
Copy link
Contributor Author

Should we just revert back to ubuntu-latest while we're at it?

In my opinion we're better off with explicit version pinning here, don't you think ?

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it then. Thanks!

@pllim pllim merged commit d04deef into astropy:main Feb 28, 2025
34 of 35 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Feb 28, 2025
…) and `uraimo/run-on-arch-action` (`v2.8.1` -> `v3.0.0`) on exotic archs
@neutrinoceros neutrinoceros deleted the revert_17804 branch February 28, 2025 20:36
pllim added a commit that referenced this pull request Mar 1, 2025
…827-on-v7.0.x

Backport PR #17827 on branch v7.0.x (MNT: bump ubuntu image (`22.04` -> `24.04`) and `uraimo/run-on-arch-action` (`v2.8.1` -> `v3.0.0`) on exotic archs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: s390x fails with pyerfa pyproject.toml does not contain a tool.setuptools_scm section TST: ppc64le fails with run-on-arch-install.sh error
3 participants