fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232
…github.com/Aaronontheweb/akka.net into 3786_AkkaPersistence_persistDuringRecovery
Aaronontheweb
commented
May 22, 2019
| public class PersistentActorRecoveryTimeoutSpec : PersistenceSpec | ||
| { | ||
| private const string JournalId = "persistent-actor-recovery-timeout-spec"; | ||
| private static readonly AtomicCounter JournalIdNumber = new AtomicCounter(0); |
There was a problem hiding this comment.
Race conditions in this test were caused by multiple parallel test cases accessing the same SteppingMemoryJournal - forced this test case to run sequentially (via the Collection attribute on the class) and made it so each SteppingMemoryJournal instance was isolated to each test case.
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
…ng_recovery (akkadotnet#3805) * fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232 * force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 30, 2019
…ng_recovery (akkadotnet#3805) * fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232 * force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232