-
Notifications
You must be signed in to change notification settings - Fork 3.6k
customise test for race between GetState and persistAsync handler #22232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
patriknw
merged 1 commit into
akka:master
from
ortibazar:wip-22052-PersistentActorSpec-2
Feb 21, 2017
Merged
customise test for race between GetState and persistAsync handler #22232
patriknw
merged 1 commit into
akka:master
from
ortibazar:wip-22052-PersistentActorSpec-2
Feb 21, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the repo owners verify this patch? |
OK TO TEST |
Test PASSed. |
patriknw
approved these changes
Feb 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for long review time here. Thanks for fixing.
I'll backport this |
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
May 21, 2019
…ng_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232
Aaronontheweb
added a commit
to akkadotnet/akka.net
that referenced
this pull request
May 22, 2019
…ng_recovery (#3805) * fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery #3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232 * force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
madmonkey
pushed a commit
to madmonkey/akka.net
that referenced
this pull request
Jul 12, 2019
…ng_recovery (akkadotnet#3805) * fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232 * force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jul 30, 2019
…ng_recovery (akkadotnet#3805) * fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232 * force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this failure, updateState handler in persistAsync(Evt("rc-3"))(updateState) processed before GetState message. And there is also chance GetState message handler may execute before this handler. So the result message may contain "rc-3" or not.
Refs #22052