Skip to content

customise test for race between GetState and persistAsync handler #22232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2017

Conversation

ortibazar
Copy link
Contributor

In this failure, updateState handler in persistAsync(Evt("rc-3"))(updateState) processed before GetState message. And there is also chance GetState message handler may execute before this handler. So the result message may contain "rc-3" or not.

Refs #22052

@akka-ci
Copy link

akka-ci commented Jan 26, 2017

Can one of the repo owners verify this patch?

@ktoso
Copy link
Contributor

ktoso commented Jan 26, 2017

OK TO TEST

@akka-ci akka-ci added validating PR is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR is currently being validated by Jenkins labels Jan 26, 2017
@akka-ci
Copy link

akka-ci commented Jan 26, 2017

Test PASSed.

Copy link
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for long review time here. Thanks for fixing.

@patriknw patriknw merged commit b3b6dc3 into akka:master Feb 21, 2017
@patriknw
Copy link
Contributor

I'll backport this

@patriknw patriknw added this to the 2.5.0 milestone Feb 21, 2017
@ortibazar ortibazar deleted the wip-22052-PersistentActorSpec-2 branch February 21, 2017 16:52
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request May 21, 2019
…ng_recovery

akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232
Aaronontheweb added a commit to akkadotnet/akka.net that referenced this pull request May 22, 2019
…ng_recovery (#3805)

* fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery

#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232

* force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
madmonkey pushed a commit to madmonkey/akka.net that referenced this pull request Jul 12, 2019
…ng_recovery (akkadotnet#3805)

* fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery

akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232

* force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jul 30, 2019
…ng_recovery (akkadotnet#3805)

* fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery

akkadotnet#3786 - fix PersistentActor_should_be_able_to_persist_events_that_happen_during_recovery by porting akka/akka#22232

* force PersistentActorRecoverySpec to use new SteppingMemoryJournal instance each time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants