Don't initialize Lmdb when rememberEntities not used, #28567 #28568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sharding defines durable.keys in reference.conf * That will trigger initialization of LmdbDurableStore for the ddata Replicator that is used by Sharding * but that is only needed if rememberEntities is enabled * This will optimize startup time for ClusterSharding, and reduced runtime complexity of accessing file system
|
I'll run this in a multi-node jenkins job to make sure nothing breaks |
|
Test PASSed. |
octonato
approved these changes
Feb 5, 2020
chbatey
approved these changes
Feb 11, 2020
|
yes, multi-node tests were fine |
zbynek001
added a commit
to zbynek001/akka.net
that referenced
this pull request
Mar 24, 2020
zbynek001
added a commit
to zbynek001/akka.net
that referenced
this pull request
Mar 26, 2020
Aaronontheweb
added a commit
to akkadotnet/akka.net
that referenced
this pull request
Mar 27, 2020
* Avoid dead letter for rebalance timeout msg migrated from akka/akka#28274 * Reconsider cluster.role.<role-name>.min-nr-of-members fallback migrated from akka/akka#28203 * Use dedicated message for PersistentShardCoodinator termination instead of PoisonPill migrated from akka/akka#28104 * Don't initialize durable keys when rememberEntities not used migrated from akka/akka#28568 * Improve error message when coordinator not found migrated from akka/akka#28576 * Shard region registration to more potential oldest * Keep track of Leaving and Exiting members in ShardRegion and attempt to register to coordinator at several of the oldest if they have status Leaving and Exiting. Include all up to and including the first member with status Up. * Sending to wrong node doesn't matter, will be suppressed deadLetter. * Same for the GracefulShutdownReq which already had that intention by sending to 2 oldest. migrated from akka/akka#28470 * Log non-completed rebalance at warning level migrated from akka/akka#28335 * api approval fix * review fixes Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ddata Replicator that is used by Sharding
and reduced runtime complexity of accessing file system
Refs #28567