Reconsider cluster.role.<role-name>.min-nr-of-members fallback #28177 #28203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
raboof
approved these changes
Nov 20, 2019
...sharding/src/multi-jvm/scala/akka/cluster/sharding/ClusterShardingRolePartitioningSpec.scala
Outdated
Show resolved
Hide resolved
| commonConfig( | ||
| ConfigFactory | ||
| .parseString(""" | ||
| akka.cluster.min-nr-of-members = 2 |
There was a problem hiding this comment.
If we make this:
Suggested change
| akka.cluster.min-nr-of-members = 2 | |
| akka.cluster.min-nr-of-members = 3 |
... then the test actually exercises the change in this PR
There was a problem hiding this comment.
The steps to replicate are:
- Cluster started
akka.cluster.min-nr-of-members=2
- 5 nodes total
- 3 nodes
akka.cluster.roles = [ "R1" ] - 2 nodes
akka.cluster.roles = [ "R2" ] - no
akka.cluster.role.*.min-nr-of-membersset
- 3 nodes
- Nodes converge
- Sharding started on all nodes for both types
- First message from an R2/E2 proxy node to an R2/E2 hosting node
- Timeout seen
However it works as expected prior to this change, could not replicate.
...sharding/src/multi-jvm/scala/akka/cluster/sharding/ClusterShardingRolePartitioningSpec.scala
Outdated
Show resolved
Hide resolved
| @@ -502,7 +502,7 @@ abstract class ShardCoordinator( | |||
| case None => | |||
| cluster.settings.MinNrOfMembers | |||
| case Some(r) => | |||
| cluster.settings.MinNrOfMembersOfRole.getOrElse(r, cluster.settings.MinNrOfMembers) | |||
| cluster.settings.MinNrOfMembersOfRole.getOrElse(r, 1) | |||
patriknw
approved these changes
Nov 20, 2019
...sharding/src/multi-jvm/scala/akka/cluster/sharding/ClusterShardingRolePartitioningSpec.scala
Outdated
Show resolved
Hide resolved
...sharding/src/multi-jvm/scala/akka/cluster/sharding/ClusterShardingRolePartitioningSpec.scala
Outdated
Show resolved
Hide resolved
|
Test PASSed. |
|
Test PASSed. |
zbynek001
added a commit
to zbynek001/akka.net
that referenced
this pull request
Mar 24, 2020
zbynek001
added a commit
to zbynek001/akka.net
that referenced
this pull request
Mar 26, 2020
Aaronontheweb
added a commit
to akkadotnet/akka.net
that referenced
this pull request
Mar 27, 2020
* Avoid dead letter for rebalance timeout msg migrated from akka/akka#28274 * Reconsider cluster.role.<role-name>.min-nr-of-members fallback migrated from akka/akka#28203 * Use dedicated message for PersistentShardCoodinator termination instead of PoisonPill migrated from akka/akka#28104 * Don't initialize durable keys when rememberEntities not used migrated from akka/akka#28568 * Improve error message when coordinator not found migrated from akka/akka#28576 * Shard region registration to more potential oldest * Keep track of Leaving and Exiting members in ShardRegion and attempt to register to coordinator at several of the oldest if they have status Leaving and Exiting. Include all up to and including the first member with status Up. * Sending to wrong node doesn't matter, will be suppressed deadLetter. * Same for the GracefulShutdownReq which already had that intention by sending to 2 oldest. migrated from akka/akka#28470 * Log non-completed rebalance at warning level migrated from akka/akka#28335 * api approval fix * review fixes Co-authored-by: Aaron Stannard <aaron@petabridge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#28177
Changes
The default fallback to global
min-nr-of-membersif a role for sharding is used now defaults to 1 instead.Background Context
There was a user case raised related to this, and a test was added to attempt to replicate the issue. However I was unable to replicate it based on the steps described by the user, which are in the test as it is understood thus far. The added test passed prior to this change, with global config for role user and not used.
Will follow up to confirm or update.