Skip to content

feat: remove dynamo deployment from cli #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 8, 2025
Merged

feat: remove dynamo deployment from cli #1742

merged 8 commits into from
Jul 8, 2025

Conversation

biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Jul 2, 2025 •
edited
Loading

Overview:

remove dynamo deployment from cli as we move from cli to based on outcome of DEP Dynamo UX v2

Details:

  • remove dynamo deployment from cli
  • Added TODO similar to below example, which will be updated in follow up PR.
# TODO: Deploy your service using dynamo graph deployment CR.

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Removals
    • Removed support for Kubernetes deployment management, including all related deployment management features and configuration options.
    • The ability to create, update, retrieve, list, or delete deployments via Kubernetes is no longer available.

@biswapanda biswapanda self-assigned this Jul 2, 2025
@github-actions github-actions bot added the feat label Jul 2, 2025
@biswapanda biswapanda marked this pull request as draft July 2, 2025 22:45
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 2, 2025

Walkthrough

This change removes the entire Kubernetes deployment manager implementation, including the KubernetesDeploymentManager class, deployment target type enum, and related module initialization files. All code related to managing deployments via Kubernetes REST API endpoints has been deleted, leaving no deployment management logic in this directory.

Changes

Files/Paths Change Summary
.../deploy/init.py Removed file containing only license and copyright headers.
.../deploy/consts.py Removed file defining the DeploymentTargetType enum with member KUBERNETES.
.../deploy/kubernetes.py Removed file implementing the KubernetesDeploymentManager class and all its public methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant KubernetesDeploymentManager
    participant REST API

    User->>KubernetesDeploymentManager: Create/Update/Get/Delete Deployment
    KubernetesDeploymentManager->>REST API: HTTP Request (POST/GET/PUT/DELETE)
    REST API-->>KubernetesDeploymentManager: Response (Status/Deployment Info)
    KubernetesDeploymentManager-->>User: Result/Exception

    %% All above interactions are now removed by this PR
Loading

Possibly related PRs

Poem

The Kubernetes code has hopped away,
No more deployments in the fray.
Enums and classes, all set free,
Leaving the folder clean as can be.
With every hop, the codebase grows light—
A rabbit’s work, tidy and bright! 🐇✨

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cbf803 and 02cc132.

📒 Files selected for processing (3)
  • deploy/sdk/src/dynamo/sdk/core/deploy/__init__.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/deploy/consts.py (0 hunks)
  • deploy/sdk/src/dynamo/sdk/core/deploy/kubernetes.py (0 hunks)
💤 Files with no reviewable changes (3)
  • deploy/sdk/src/dynamo/sdk/core/deploy/init.py
  • deploy/sdk/src/dynamo/sdk/core/deploy/consts.py
  • deploy/sdk/src/dynamo/sdk/core/deploy/kubernetes.py
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: pre-commit
  • GitHub Check: Build and Test - vllm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@biswapanda biswapanda added the dynamo-deploy Relates to dynamo-deploy binary label Jul 2, 2025
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Jul 2, 2025
@biswapanda biswapanda marked this pull request as ready for review July 2, 2025 23:10
@biswapanda
Copy link
Contributor Author

I think there's also some stuff to remove in sdk/protocol/deployment.py (if not that whole file)

Thanks Hannah, Removed now redundant files from sdk/protocol/deployment.py

@biswapanda biswapanda enabled auto-merge (squash) July 3, 2025 01:10
whoisj
whoisj reviewed Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@whoisj whoisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the markdown, but had a few questions about it.

@biswapanda biswapanda disabled auto-merge July 3, 2025 18:31
@biswapanda biswapanda changed the title feat: remove dynamo deployment from cli feat: remove dynamo deployment from cli [DO NOT MERGE] Jul 3, 2025
@galletas1712 galletas1712 mentioned this pull request Jul 3, 2025
Merged
atchernych
atchernych reviewed Jul 7, 2025
View reviewed changes
atchernych
atchernych reviewed Jul 7, 2025
View reviewed changes
@biswapanda biswapanda changed the title feat: remove dynamo deployment from cli [DO NOT MERGE] feat: remove dynamo deployment from cli Jul 7, 2025
@biswapanda biswapanda enabled auto-merge (squash) July 7, 2025 23:55
@nnshah1 nnshah1 disabled auto-merge July 8, 2025 13:21
@nnshah1 nnshah1 merged commit fbd1f8d into main Jul 8, 2025
14 of 16 checks passed
@nnshah1 nnshah1 deleted the bis/dyn-660-clean-up-old-dynamo-deployment-code branch July 8, 2025 13:21
atchernych pushed a commit that referenced this pull request Jul 9, 2025
@biswapanda @atchernych
feat: remove dynamo deployment from cli (#1742)
8bd82a5
@coderabbitai coderabbitai bot mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whoisj whoisj whoisj left review comments

@atchernych atchernych atchernych approved these changes

@tedzhouhk tedzhouhk tedzhouhk approved these changes

@nnshah1 nnshah1 nnshah1 approved these changes

@mohammedabdulwahhab mohammedabdulwahhab mohammedabdulwahhab approved these changes

@PeaBrane PeaBrane PeaBrane approved these changes

@hhzhang16 hhzhang16 hhzhang16 approved these changes

@ishandhanani ishandhanani ishandhanani approved these changes

@hutm hutm Awaiting requested review from hutm hutm is a code owner

@julienmancuso julienmancuso Awaiting requested review from julienmancuso julienmancuso is a code owner

@indrajit96 indrajit96 Awaiting requested review from indrajit96 indrajit96 is a code owner

@krishung5 krishung5 Awaiting requested review from krishung5 krishung5 is a code owner

@alec-flowers alec-flowers Awaiting requested review from alec-flowers alec-flowers is a code owner

@grahamking grahamking Awaiting requested review from grahamking

@GuanLuo GuanLuo Awaiting requested review from GuanLuo

@kkranen kkranen Awaiting requested review from kkranen

@piotrm-nvidia piotrm-nvidia Awaiting requested review from piotrm-nvidia

@ptarasiewiczNV ptarasiewiczNV Awaiting requested review from ptarasiewiczNV

@rmccorm4 rmccorm4 Awaiting requested review from rmccorm4

@tanmayv25 tanmayv25 Awaiting requested review from tanmayv25

Assignees

@biswapanda biswapanda

Labels
dynamo-deploy Relates to dynamo-deploy binary feat size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@biswapanda @tedzhouhk @whoisj @nnshah1 @mohammedabdulwahhab @PeaBrane @hhzhang16 @ishandhanani @atchernych