feat: remove bento cloud deploy target, set deployment target to kubernetes by default #1247

hhzhang16 · 2025-05-28T18:56:49Z

Overview:

Removed bento cloud deployment target and set default deployment target to "kubernetes" so it becomes optional for users.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

closes GitHub issue: #xxx

Summary by CodeRabbit

Refactor
- Improved deployment target handling in the CLI by introducing an enum-based approach for target selection, enhancing type safety and validation.
- Standardized the deployment target option to default to Kubernetes across all relevant CLI commands.
New Features
- Added a new deployment target type enumeration for clearer and more consistent target specification.
Bug Fixes
- Improved error handling and messaging for invalid deployment targets.
Revert
- Removed support for the "bento_cloud" deployment target and its associated functionality from the CLI.

coderabbitai · 2025-05-28T18:56:57Z

Walkthrough

The changes refactor deployment target handling in the CLI by introducing a DeploymentTargetType enum, defaulting all deployment commands to use Kubernetes as the target. The code now validates targets using this enum, centralizes error handling, and removes support for the "bento_cloud" deployment target, including deleting its manager implementation.

Changes

File(s)	Change Summary
deploy/sdk/src/dynamo/sdk/cli/deployment.py	Refactored to use `DeploymentTargetType` enum for target handling; default target is now Kubernetes; removed bento_cloud support; improved error handling.
deploy/sdk/src/dynamo/sdk/core/deploy/consts.py	Added new file defining `DeploymentTargetType` enum with `KUBERNETES` as the only member.
deploy/sdk/src/dynamo/sdk/core/deploy/bento_cloud.py	Deleted file; removed `BentoCloudDeploymentManager` class and all related deployment management methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant DeploymentManager

    User->>CLI: Run deployment command (create, update, get, etc.)
    CLI->>CLI: Parse --target option (default: kubernetes)
    CLI->>CLI: Convert target string to DeploymentTargetType enum
    alt Valid target
        CLI->>DeploymentManager: Perform deployment operation (based on command)
        DeploymentManager-->>CLI: Return result/status
        CLI-->>User: Output result
    else Invalid target
        CLI->>User: Print error panel and exit
    end

Poem

Oh, enum of targets, you’re tidy and neat,
No more cloud confusion, just Kubernetes at our feet!
The code is now safer, with errors well caught,
The bento cloud’s gone, but progress is not.
🐰 Hopping ahead, the deployments are bright—
With enums and structure, we code through the night!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a1d1fb and 32da82f.

📒 Files selected for processing (3)

deploy/sdk/src/dynamo/sdk/cli/deployment.py (10 hunks)
deploy/sdk/src/dynamo/sdk/core/deploy/bento_cloud.py (0 hunks)
deploy/sdk/src/dynamo/sdk/core/deploy/consts.py (1 hunks)

💤 Files with no reviewable changes (1)

deploy/sdk/src/dynamo/sdk/core/deploy/bento_cloud.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: Mirror Repository to GitLab
GitHub Check: Build and Test - vllm

🔇 Additional comments (11)

deploy/sdk/src/dynamo/sdk/core/deploy/consts.py (1)

19-22: LGTM! Clean enum implementation for deployment targets.

The DeploymentTargetType enum is well-implemented with proper documentation. The single KUBERNETES value aligns with the PR objective to remove bento_cloud support and simplify deployment targeting.

deploy/sdk/src/dynamo/sdk/cli/deployment.py (10)

28-28: LGTM! Proper import of the new enum.

The import statement correctly brings in the DeploymentTargetType enum for use in the CLI commands.

48-63: Excellent error handling and validation implementation.

The enhanced get_deployment_manager function provides robust validation:

Converts string targets to enum values with proper error handling

Displays user-friendly error messages using rich panels

Lists valid targets dynamically from the enum

Maintains backward compatibility while enforcing type safety

The implementation correctly handles the removal of bento_cloud support through enum validation.

137-142: LGTM! Consistent default to Kubernetes deployment.

The _handle_deploy_create function now defaults to DeploymentTargetType.KUBERNETES.value, making the target parameter optional as intended in the PR objectives.

256-261: LGTM! Consistent parameter update for create command.

The create command properly defaults to Kubernetes deployment target, maintaining consistency with other commands.

273-278: LGTM! Consistent parameter update for get command.

The get command properly defaults to Kubernetes deployment target.

292-292: Good cleanup in exception handling.

The unused URL variable has been properly removed from the tuple unpacking, improving code cleanliness.

314-319: LGTM! Consistent parameter update for list command.

The list_deployments command properly defaults to Kubernetes deployment target.

363-368: LGTM! Consistent parameter update for update command.

The update command properly defaults to Kubernetes deployment target.

432-437: LGTM! Consistent parameter update for delete command.

The delete command properly defaults to Kubernetes deployment target.

495-500: LGTM! Consistent parameter update for deploy command.

The deploy command properly defaults to Kubernetes deployment target, completing the consistent update across all CLI commands.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…rnetes by default (#1247)

feat: remove bento cloud, set deployment target to kubernetes by default

32da82f

hhzhang16 requested review from hutm, biswapanda, ishandhanani, julienmancuso, nnshah1 and mohammedabdulwahhab as code owners May 28, 2025 18:56

pull-request-size bot added the size/L label May 28, 2025

copy-pr-bot bot temporarily deployed to GITLAB May 28, 2025 18:56 Inactive

github-actions bot added the feat label May 28, 2025

copy-pr-bot bot temporarily deployed to GITLAB May 28, 2025 18:58 Inactive

mohammedabdulwahhab approved these changes May 28, 2025

View reviewed changes

hhzhang16 merged commit f57864e into main May 28, 2025
14 checks passed

hhzhang16 deleted the hannahz/remove-bento-cloud branch May 28, 2025 19:37

pvijayakrish pushed a commit that referenced this pull request May 29, 2025

feat: remove bento cloud deploy target, set deployment target to kube…

30883bf

…rnetes by default (#1247)

coderabbitai bot mentioned this pull request Jul 2, 2025

feat: remove dynamo deployment from cli #1742

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: remove bento cloud deploy target, set deployment target to kubernetes by default #1247

feat: remove bento cloud deploy target, set deployment target to kubernetes by default #1247

Uh oh!

hhzhang16 commented May 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 28, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

feat: remove bento cloud deploy target, set deployment target to kubernetes by default #1247

feat: remove bento cloud deploy target, set deployment target to kubernetes by default #1247

Uh oh!

Conversation

hhzhang16 commented May 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

hhzhang16 commented May 28, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)