oci: blobcompress: switch to Docker-friendly gzip block size #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory larger layer data should make it easier to notice unintentional changes to our compressed layer output. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
According to the stacker folks, having a parameter that mismatches with Docker will result in layers getting recompressed. Based on my testing, the hashes of random layer data doesn't change but I guess it's possible it could change in certain situations and we should just match their settings. Ideally this would be configurable but since stacker is the only thing that cares about this for the moment, we may as well just follow their default setting (which -- it turns out -- is the new pgzip default setting too). Suggested-by: Ramkumar Chinchani <rchincha@cisco.com> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 72.72% 72.85% +0.12%
==========================================
Files 65 67 +2
Lines 5089 5393 +304
==========================================
+ Hits 3701 3929 +228
- Misses 1010 1089 +79
+ Partials 378 375 -3
🚀 New features to boost your workflow:
|
cyphar
added a commit
to cyphar/stacker
that referenced
this pull request
May 31, 2025
This allows us to switch away from our umoci fork now that upstream supports OverlayfsRootfs and the various features we need. The key changes that allow us to switch away from our fork are: * opencontainers/umoci#572 which implemented a large number of fixes to overlayfs handling, such as opaque whiteouts and several features not implemented in our fork (xattr escaping, handling of missing parent directories, improved rootless support, handling of nested whiteouts inside an opaque whiteout). * opencontainers/umoci#581 which switched to a Docker-friendly gzip block size by default, removing the need to configure it (as suggested in opencontainers/umoci#509). * opencontainers/umoci#587 which implemented full configurable userxattr (user.overlay.*) support. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
rchincha
pushed a commit
to project-stacker/stacker
that referenced
this pull request
May 31, 2025
* feat: update to skopeo v1.13.0 We need to update skopeo to match the pgzip version between skopeo and umoci. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> * feat: update to github.com/opencontainers/umoci@v0.5.0 This allows us to switch away from our umoci fork now that upstream supports OverlayfsRootfs and the various features we need. The key changes that allow us to switch away from our fork are: * opencontainers/umoci#572 which implemented a large number of fixes to overlayfs handling, such as opaque whiteouts and several features not implemented in our fork (xattr escaping, handling of missing parent directories, improved rootless support, handling of nested whiteouts inside an opaque whiteout). * opencontainers/umoci#581 which switched to a Docker-friendly gzip block size by default, removing the need to configure it (as suggested in opencontainers/umoci#509). * opencontainers/umoci#587 which implemented full configurable userxattr (user.overlay.*) support. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> --------- Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the stacker folks, having a parameter that mismatches with
Docker will result in layers getting recompressed. Based on my testing,
the hashes of random layer data doesn't change but I guess it's possible
it could change in certain situations and we should just match their
settings.
Ideally this would be configurable but since stacker is the only thing
that cares about this for the moment, we may as well just follow their
default setting (which -- it turns out -- is the new pgzip default
setting too).
Closes #509
Suggested-by: Ramkumar Chinchani rchincha@cisco.com
Signed-off-by: Aleksa Sarai cyphar@cyphar.com