feat: update to github.com/opencontainers/umoci@v0.5.0 #694
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 60.44% 60.35% -0.10%
==========================================
Files 59 59
Lines 6457 6444 -13
==========================================
- Hits 3903 3889 -14
- Misses 1908 1910 +2
+ Partials 646 645 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! This looks great. |
|
Updated to use the actual release. This is missing some of the patches from your fork, so I would suggest doing some extra testing to make sure that I didn't subtly break anything (in particular, all of the lowerdir tracking isn't in umoci because it wasn't necessary to implement the minimal version of plain-to-opaque whiteout conversion). |
|
WDYT @rchincha? |
|
CI Failure related to this. IIRC, we were trying to keep stacker and skopeo in sync wrt layer compression else they would change underneath us. |
|
https://github.com/project-stacker/stacker/blob/main/Makefile#L45 Can this be bumped to 1.13.0? |
We need to update skopeo to match the pgzip version between skopeo and umoci. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
|
@rchincha Sure, pushed. |
|
The main changes afaict between skopeo 1.9.3 ... 1.13.0 are: |
|
Have run the CI multiple times without any failures now. |
This allows us to switch away from our umoci fork now that upstream supports OverlayfsRootfs and the various features we need. The key changes that allow us to switch away from our fork are: * opencontainers/umoci#572 which implemented a large number of fixes to overlayfs handling, such as opaque whiteouts and several features not implemented in our fork (xattr escaping, handling of missing parent directories, improved rootless support, handling of nested whiteouts inside an opaque whiteout). * opencontainers/umoci#581 which switched to a Docker-friendly gzip block size by default, removing the need to configure it (as suggested in opencontainers/umoci#509). * opencontainers/umoci#587 which implemented full configurable userxattr (user.overlay.*) support. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
This allows us to switch away from our umoci fork now that upstream
supports OverlayfsRootfs and the various features we need.
Signed-off-by: Aleksa Sarai cyphar@cyphar.com