ipq806x: Revert "ipq806x: swap lan leds for Meraki MR52" #16779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"cherry selected from commit" should be set only after merging the commit because its number will change. |
5ac8f4f to
7929ae9
Compare
D'oh, good point. Per the advice in #16775, going to close that and will wait for this to be merged and then backport. Updated to remove the cherry-pick. |
7929ae9 to
f723337
Compare
|
Please allow editing by maintainers or rebase this |
Will rebase shortly -- but what do I need to do to allow editing by maintainers? |
There should be a tick in the PR itself around the Participants info |
f723337 to
f150596
Compare
Hmm, I rebased but I can't find this option either when looking at the PR in either https://github.com/openwrt/openwrt or my (org) fork's. GitHub help agrees with your assertion that there should be a checkbox, but I don't see it :/ |
For the record: this appears to be because I forked into an org: https://github.com/orgs/community/discussions/5634 :/ |
|
Moved my repos around so that the base repo is now in my personal account and the second-hand clones for various other OpenWRT projects / hardware support forks are in my org, and enabled maintainer edits. |
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
f150596 to
b5e1544
Compare
|
Thanks! Rebased on top of main and merged! |
rkboni
added a commit
to rkboni/openwrt
that referenced
this pull request
Oct 30, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit b5e1544) Signed-off-by: Rafal Boni <rafal.boni@gmail.com>
rkboni
added a commit
to rkboni/openwrt
that referenced
this pull request
Oct 30, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit b5e1544) Signed-off-by: Rafal Boni <rafal.boni@gmail.com>
rkboni
added a commit
to rkboni/openwrt
that referenced
this pull request
Oct 30, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com> (cherry picked from commit b5e1544) Signed-off-by: Rafal Boni <rafal.boni@gmail.com>
robimarko
pushed a commit
to rkboni/openwrt
that referenced
this pull request
Oct 31, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 (cherry picked from commit b5e1544) Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16822 Signed-off-by: Robert Marko <robimarko@gmail.com>
1 task
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 13, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 14, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
vincejv
pushed a commit
to vincejv/openwrt
that referenced
this pull request
Nov 14, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
Ra2-IFV
pushed a commit
to Ra2-IFV/openwrt
that referenced
this pull request
Nov 14, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
Vladdrako
pushed a commit
to Vladdrako/openwrt
that referenced
this pull request
Dec 11, 2024
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
M3m3M4n
pushed a commit
to M3m3M4n/openwrt
that referenced
this pull request
Feb 16, 2025
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
maurerr
pushed a commit
to maurerr/openwrt
that referenced
this pull request
Apr 9, 2025
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Link: openwrt#16779 Signed-off-by: Robert Marko <robimarko@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipq806x: Revert "ipq806x: swap lan leds for Meraki MR52"
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed.
I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface.
Signed-off-by: Rafal Boni rafal.boni@gmail.com