Revert "ipq806x: swap lan leds for Meraki MR52" #16775
Conversation
|
To preserve the order of interfaces in the dts file, replace the gpios number instead of changing the names. |
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed. I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface. Signed-off-by: Rafal Boni <rafal.boni@gmail.com> Re-order the interfaces so they're in numberic order again.
02bdbf9 to
4776f52
Compare
|
Does the problem also occur in snapshot (kernel 6.6)? |
I don't have a spare system to test |
Per https://forum.openwrt.org/t/cisco-meraki-mr52-no-dns-after-upgrade-to-23-05-3/194709/97, the LEDs are still backwards in |
|
Not sure if it needs to be more complicated than 2 PRs one here and one for |
|
All changes/fixes need to go to main first, and can then be backported to branches as appropriate, unless the fix is for something only in that branch, e.g. updated kernel release for a version not in main anymore. |
|
Closing and will back-port once #16775 is merged. |
This reverts commit ec8f647, as with the current kernel version, the change actually causes the same bug it once may have fixed -- that is, the leds are now again reversed.
I suspect this was due to a switch to a newer kernel version between when the patch was submitted and now reversing the order of the interfaces, so that eth0 / the LAN interface is also the interface used for PoE, and eth1 / the WAN interface is the non-PoE interface.