Skip to content

Conversation

wanghonglie
Copy link

@wanghonglie wanghonglie commented Oct 19, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

use seg_suffix to resolve the #6490

Modification

Please briefly describe what modification is made in this PR.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 64.17% // Head: 64.10% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e28a77c) compared to base (09bc48c).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9078      +/-   ##
==========================================
- Coverage   64.17%   64.10%   -0.07%     
==========================================
  Files         361      361              
  Lines       29543    29539       -4     
  Branches     5023     4921     -102     
==========================================
- Hits        18958    18935      -23     
- Misses       9580     9590      +10     
- Partials     1005     1014       +9     
Flag Coverage Δ
unittests 64.10% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/coco.py 58.22% <0.00%> (ø)
mmdet/datasets/custom.py 61.45% <100.00%> (ø)
mmdet/utils/setup_env.py 68.00% <0.00%> (-24.00%) ⬇️
mmdet/datasets/builder.py 45.83% <0.00%> (-7.30%) ⬇️
mmdet/models/dense_heads/dense_test_mixins.py 40.74% <0.00%> (-2.47%) ⬇️
mmdet/utils/misc.py 62.22% <0.00%> (-2.23%) ⬇️
mmdet/models/roi_heads/test_mixins.py 50.71% <0.00%> (-2.15%) ⬇️
mmdet/datasets/pipelines/transforms.py 75.80% <0.00%> (-0.20%) ⬇️
mmdet/datasets/samplers/infinite_sampler.py 25.31% <0.00%> (+0.62%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZwwWayne
Copy link
Collaborator

This PR also needs to be migrated to MMDet dev-3.x

@ZwwWayne ZwwWayne merged commit 92dd59e into open-mmlab:dev Oct 20, 2022
@ZwwWayne ZwwWayne mentioned this pull request Oct 20, 2022
@wanghonglie wanghonglie deleted the support_suffix branch October 20, 2022 08:56
SakiRinn pushed a commit to SakiRinn/mmdetection-locount that referenced this pull request Mar 17, 2023
* fix jpg->png

* fix jpg->png again

* add suffix

* fix lint

* rm img_suffix

* rename

Co-authored-by: Neesky <945823487@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants