Skip to content

Conversation

Neesky
Copy link

@Neesky Neesky commented Nov 12, 2021

Motivation

When I use the htc network, a certain file name of the picture in stuffthingmaps is xxxxjpgxxx.jpg, and the conversion method of the original code will make it become xxxxpngxxx.png. I think this is extremely unreasonable, so I modified it.

Modification

From seg_map = img_info['filename'].replace('jpg', 'png')
To seg_map = img_info['filename'].split(".")[0] + ".png"

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2021

CLA assistant check
All committers have signed the CLA.

@ZwwWayne
Copy link
Collaborator

Lint failed. Should fix it before merging. Please click the detail here
image

@RangiLyu
Copy link
Member

Hi, we have fixed the compatibility with MMCV in v2.18.1. Now the CI can work normally. Please pull the latest master and re-run the unit tests.
And please run pre-commit run --all-files to fix the lint.

@Neesky
Copy link
Author

Neesky commented Nov 16, 2021

I had pulled the latest master, but I can't understand how to re-run the unit tests.
And I cannot run this command: pre-commit run --all-files. Because bash: pre-commit: command not found
I am new to github, sorry for so many questions .

@RangiLyu
Copy link
Member

I had pulled the latest master, but I can't understand how to re-run the unit tests.

Just push your commit. The GitHub action will trigger the unit tests automatically.

And I cannot run this command: pre-commit run --all-files. Because bash: pre-commit: command not found I am new to
github, sorry for so many questions .

Run pip install pre-commit

@Neesky
Copy link
Author

Neesky commented Nov 16, 2021

I have pulled the latest master and re-run the unit tests.
But when I use command pre-commit run --all-files, A bug has occurred

An unexpected error has occurred: CalledProcessError: command: ('rbenv', 'init', '-')
return code: 1
expected return code: 0
stdout:
    Executable `rbenv` not found

Maybe it's because my current system is windows10.
So, is the command pre-commit run --all-files necessary? What should I do to solve this problem?

@ZwwWayne
Copy link
Collaborator

image
Hi, the main issue is in the whitespace. You can also use https://github.com/open-mmlab/mmdetection/blob/master/.dev_scripts/linter.sh

@ZwwWayne
Copy link
Collaborator

Can we use img_prefix and seg_prefix to resolve this issue just like those in mmseg? see example here https://github.com/open-mmlab/mmsegmentation/blob/master/mmseg/datasets/custom.py#L82

@alfialdo
Copy link

is this issue solved?

@ZwwWayne ZwwWayne changed the base branch from master to dev October 18, 2022 04:41
@ZwwWayne ZwwWayne added this to the 2.27.0 milestone Oct 18, 2022
@wanghonglie wanghonglie mentioned this pull request Oct 19, 2022
@ZwwWayne
Copy link
Collaborator

Resolved in #9078

@ZwwWayne ZwwWayne closed this Oct 20, 2022
@OpenMMLab-Assistant005
Copy link

Hi @Neesky !We are grateful for your efforts in helping improve this open-source project during your personal time.
Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA
If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants