Remove 64 column limits, Add some Bit array and vector functions and operator overloadings #5305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add operator overrides and more functions for bit vector and arrays
This commit fixes remain boundary issues.
|
This creates 4 extra heap allocations per table which is not acceptable unfortunately (both in term of allocations count and in terms of extra indirection and strain on cache lines). Those buffers would need to be included in the single table->RawData buffer while keeping usage terse and obvious. I also don't think overriding |
Closed
ocornut
added a commit
that referenced
this pull request
Jan 20, 2023
|
Now pushed an official change for that: lifting limits and performances are equivalent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be remove column limits, mentioned into #3572.
Also, I add useful functions for Bit array and vectors, for future expansion and usage.