Skip to content

Tables: Allow more than 64 columns #4876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tables: Allow more than 64 columns #4876

wants to merge 1 commit into from

Conversation

0lru
Copy link

@0lru 0lru commented Jan 7, 2022

This belongs to issue #3572

It allows using more than 64 columns in a table. I've applied the patches mentioned in #3572. Just the "IsEqual" method was missing there.

@0lru 0lru mentioned this pull request Jan 7, 2022
Closed
@ocornut ocornut force-pushed the master branch 2 times, most recently from b3b85d8 to 0755767 Compare January 17, 2022 14:21
@retifrav retifrav mentioned this pull request Jan 20, 2022
Closed
@ocornut ocornut force-pushed the master branch 3 times, most recently from c817acb to 8d39063 Compare February 15, 2022 16:25
ocornut added a commit that referenced this pull request Jan 20, 2023
@ocornut
Tables: removed hot RequestOutputMaskByIndex bit-array as majority of…
db55422 
… code-paths are already touching the cold parts.

Only exception being TableSetColumnIndex() with same column number but that's an odd case.
Will break PR #6094 #3572 #5305 #4876 but those not need to be necessarily updated: we got enough reference to finish that feature.
ocornut added a commit that referenced this pull request Jan 20, 2023
@ocornut
Tables: increase table columns limit from 64 to 512 using bit array a…
9166743 
…llocated in contiguous memory +. (#6094, #5305, #4876, #3572)
@ocornut ocornut mentioned this pull request Jan 20, 2023
Closed
@ocornut
Copy link
Owner

ocornut commented Jan 20, 2023

Now pushed an official change for that: lifting limits and performances are equivalent.
See details on this comment : #6094 (comment)

@ocornut ocornut closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tables/columns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0lru @ocornut