Check if item has been removed before firing OnItemMoved events #3925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSpeichert
approved these changes
Feb 6, 2022
ghost
approved these changes
Feb 6, 2022
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Feb 23, 2022
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Followup to #3918
This fixes an edge case when an item would be removed just before the
onItemMovedevent would execute, e.g. when throwing an item into a trash holder (water, lava, dustbin etc). The pointer would still be valid but the item would be flagged for removal.Issues addressed: