Skip to content

Fix OnItemMoved event when the last item of a stackable stack is move… #3918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

Fix OnItemMoved event when the last item of a stackable stack is move… #3918

merged 1 commit into from
Jan 31, 2022

Conversation

Erza
Copy link
Contributor

@Erza Erza commented Jan 31, 2022 •
edited
Loading

…d into another stack

Pull Request Prelude

Changes Proposed

Followup to #3916
A crash would occur when moving, for example, a stack of a single gold coin into another stack of gold coins.
The crash would only occur when the last item of a stack was being moved, aka. the stack being destroyed.

Old output of this scenario:

New output of this scenario:

==========================
=== Player:onItemMoved ===
==========================
{
    ["toCylinder"] = userdata: 0x06b4fc80,
    ["fromCylinder"] = userdata: 0x06b4fc58,
    ["count"] = 5,
    ["toPosition"] = {
        ["y"] = 64,
        ["x"] = 65535,
        ["z"] = 0,
        ["stackpos"] = 0
    },
    ["item"] = {
        ["type"] = 100,
        ["itemid"] = 2148,
        ["uid"] = 65544,
        ["actionid"] = 0
    },
    ["fromPosition"] = {
        ["y"] = 66,
        ["x"] = 65535,
        ["z"] = 1,
        ["stackpos"] = 0
    }
}
==========================

Issues addressed:

@ghost ghost requested review from a team January 31, 2022 08:05
@ghost ghost added the bugfix label Jan 31, 2022
Znote
Znote approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@Znote Znote left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced crash:
itemcrash1

Applied this PR, crash fixed:
itemcrash2

Ohh yeah, I'm rocking OTClient with Protocol 12 😎

@Znote Znote merged commit b238500 into otland:master Jan 31, 2022
@Erza Erza mentioned this pull request Feb 6, 2022
Merged
3 tasks
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Feb 23, 2022
@Erza @Znote
Fix OnItemMoved event when the last item of a stackable stack is move…
c11befc 
…d into another stack (otland#3918)

A crash would occur when moving, for example, a stack of a single gold coin into another stack of gold coins.
The crash would only occur when the last item of a stack was being moved, aka. the stack being destroyed.
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@Erza @DSpeichert
Fix OnItemMoved event when the last item of a stackable stack is move…
c27f058 
…d into another stack (#3918)

A crash would occur when moving, for example, a stack of a single gold coin into another stack of gold coins.
The crash would only occur when the last item of a stack was being moved, aka. the stack being destroyed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Znote Znote Znote approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Erza @Znote