[RFC] external command line with colors #7173
Conversation
55bee32 to
2980f51
Compare
|
Update: actually transmit contents of blocks. b/w for now, but could support coloring later on. Also blocks could be retransmitted from start, in case parser changed highlight of earlier code because later code. Todo: This should also be done on |
7544259 to
1337ebd
Compare
|
Marking RFC. Testing by external UI implementors would be appreciated. |
|
Note to self: test handling of |
529b26f to
fd2a03e
Compare
8cf85cc to
00e8f32
Compare
|
@justinmk and others, what do you think of splitting of "6. Remote Uis" into its own help file? As the UI protocol gets more rich it is arguably not just "serialization" anymore, rather its own collection of features. |
|
@bfredl I was hoping to put it in a new section in or something like that. Haven't done it yet because I was also hoping it could be generated by |
|
@justinmk I just pushed a WIP proposal. Please look at general structure, it is knowingly full of broken formatting and references... Auto-generation would be useful, but I would have a shot at that in a separate PR. we can figure out the target structure first... |
|
I wouldn't like |
runtime/doc/api.txt
Outdated
| @@ -48,7 +48,7 @@ version.api_compatible API is backwards-compatible with this level | |||
| version.api_prerelease Declares the current API level as unstable > | |||
| (version.api_prerelease && fn.since == version.api_level) | |||
| functions API function signatures | |||
| ui_events UI event signatures |rpc-remote-ui| | |||
| ui_events UI event signatures |remote-ui| | |||
There was a problem hiding this comment.
|ui| is sufficient. Just like we claimed |api|, we can make "UI" a single idea when communicating with users. Details about "msgpack" and "remote" don't need to be called out in most contexts.
Or |api-ui| if we really need the distinction.
runtime/doc/remote_ui.txt
Outdated
| most 256 different colors). | ||
| `ext_popupmenu` Externalize the popupmenu. |ui-events-popupmenu| | ||
| `ext_tabline` Externalize the tabline. |ui-events-tabline| | ||
| `ext_cmdline` Externalize the cmdline. |ui-events-cmdline| |
There was a problem hiding this comment.
I would prefer to keep the tags ui-ext-foo. "ext" is the token that means extensible/external widget.
There was a problem hiding this comment.
the point was to make it in line with ui-events-grid and ui-events-mode. Or we could reverse them and have ui-events-global and then ui-events-grid, the "grid" is some sense a widget, just the most important one. When we get multi-grid support I would rather have a "set current grid" event (prefixed in every update batch) than duplicating every single grid event (alternatively, add it as a field to every event).
There was a problem hiding this comment.
Maybe neither is needed: ui-grid, ui-mode, ui-tabline, ...
In all other contexts the ui- prefix is omitted, this means it's an editor feature.
runtime/doc/remote_ui.txt
Outdated
| ============================================================================== | ||
| 3. External Popupmenu Events *ui-events-popupmenu* | ||
|
|
||
| Only sent if `ext_popupmenu` option is set in *remote-ui-options* |
There was a problem hiding this comment.
*ui-options*. Let's move away from remote- prefix except where it's absolutely needed.
add cchar_to_string
4f982b4 to
ddb5da2
Compare
| typically used to indicate a pending state, like right after Ctrl-V. | ||
| if shift is true the text after the cursor should be shifted, | ||
| otherwise it should overshadow the char at the cursor. | ||
| Should be hidden at next cmdline_char |
There was a problem hiding this comment.
@bfredl should cmdline_char be cmdline_pos?
(Just let me know; I'll fix it during merge)
FEATURES: 0e873a3 Lua(Jit) built-in neovim#4411 5b32bce Windows: `:terminal` neovim#7007 7b0ceb3 UI/API: externalize cmdline neovim#7173 b67f58b UI/API: externalize wildmenu neovim#7454 b23aa1c UI: 'winhighlight' neovim#6597 17531ed UI: command-line coloring (`:help input()-highlight`) neovim#6364 244a1f9 API: execute lua directly from the remote api neovim#6704 45626de API: `get_keymap()` neovim#6236 db99982 API: `nvim_get_hl_by_name()`, `nvim_get_hl_by_id()` neovim#7082 dc68538 menu_get() function neovim#6322 9db42d4 :cquit : take an error code argument neovim#7336 9cc185d job-control: serverstart(): support ipv6 neovim#6680 1b7a9bf job-control: sockopen() neovim#6594 6efe84a clipboard: fallback to tmux clipboard neovim#6894 6016ac2 clipboard: customize clipboard with `g:clipboard` neovim#6030 3a86dd5 ruby: override ruby host via `g:ruby_host_prog` neovim#6841 16cce1a debug: $NVIM_LOG_FILE neovim#6827 0cba3da `:checkhealth` built-in, validates $VIMRUNTIME neovim#7399 FIXES: 105d680 TUI: more terminals, improve scroll/resize neovim#6816 cb912a3 :terminal : handle F1-F12, other keys neovim#7241 619838f inccommand: improve performance neovim#6949 04b3c32 inccommand: Fix matches for zero-width neovim#7487 60b1e8a inccommand: multiline, other fixes neovim#7315 f1f7f3b inccommand: Ignore leading modifiers in the command neovim#6967 1551f71 inccommand: fix 'gdefault' lockup neovim#7262 6338199 API: bufhl: support creating new groups neovim#7414 541dde3 API: allow K_EVENT during operator-pending 8c732f7 terminal: adjust for 'number' neovim#7440 5bec946 UI: preserve wildmenu during jobs/events neovim#7110 c349083 UI: disable 'lazyredraw' during ui_refresh. neovim#6259 51808a2 send FocusGained/FocusLost event instead of pseudokey neovim#7221 133f8bc shada: preserve unnamed register on restart neovim#4700 1b70a1d shada: avoid assertion on corrupt shada file neovim#6958 9f534f3 mksession: Restore tab-local working directory neovim#6859 de1084f fix buf_write() crash neovim#7140 7f76986 syntax: register 'Normal' highlight group neovim#6973 6e7a8c3 RPC: close channel if stream was closed neovim#7081 85f3084 clipboard: disallow recursion; show hint only once neovim#7203 8d1ccb6 clipboard: performance, avoid weird edge-cases neovim#7193 01487d4 'titleold' neovim#7358 01e53a5 Windows: better path-handling, separator (slash) hygiene neovim#7349 0f2873c Windows: multibyte startup arguments neovim#7060 CHANGES: 9ff0cc7 :terminal : start in normal-mode neovim#6808 032b088 lower priority of 'cursorcolumn', 'colorcolumn' neovim#7364 2a3bcd1 RPC: Don't delay notifications when request is pending neovim#6544 023f67c :terminal : Do not change 'number', 'relativenumber' neovim#6796 1ef2d76 socket.c: Disable Nagle's algorithm on TCP sockets neovim#6915 6720fe2 help: `K` tries Vim help instead of manpage neovim#3104 7068370 help, man.vim: change "outline" map to `gO` neovim#7405
Rebase of #6162 with highlight support added. Rather than group names, I think it is better to transmit highlight than name, because that opens up for combined highlights in the future (think a builtin parser + rainbow parens as plugin).
Docs are still WIP. And needs more tests.
I also borrowed a function from #7082 for converting highlights.