Skip to content

Conversation

MauriceVanVeen
Copy link
Member

Nats-Expected-Last-Subject-Sequence-Subject and Nats-Expected-Last-Subject-Sequence share a common prefix. We could not get the proper value for the latter header depending on the ordering in the headers.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner July 15, 2025 14:40
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think it might be worth considering pulling in all headers to a pooled struct that has any header that the server may want to react against.

@neilalexander
Copy link
Member

I think that's a good idea, but suggest we tackle that separately.

@derekcollison
Copy link
Member

I did not mean in this PR.

@neilalexander neilalexander merged commit fbced92 into main Jul 15, 2025
48 checks passed
@neilalexander neilalexander deleted the maurice/slice-header branch July 15, 2025 14:56
neilalexander added a commit that referenced this pull request Jul 25, 2025
Includes the following:

- #7031
- #7033
- #7034
- #7035
- #7036
- #7040
- #7043
- #7045
- #7047
- #7046
- #7050
- #7051
- #7052
- #7053
- #7061
- #7063
- #7064
- #7065
- #7066
- #7070
- #7072
- #7080
- #7026
- #6728
- #7074
- #7089
- #7095
- #7087
- #7094
- #7096
- #7099

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants