Skip to content

[ADDED] Add fuzz tests #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

[ADDED] Add fuzz tests #6728

merged 1 commit into from
Jul 21, 2025

Conversation

astmix
Copy link

@astmix astmix commented Mar 26, 2025 •
edited
Loading

Add fuzz tests:

  1. Protocol parsing (adapting the previous test)
  2. TLS handshake validation
  3. Subject collision detection.

Signed-off-by: Sergey Sobolev seregasobolev96@gmail.com

@astmix astmix requested a review from a team as a code owner March 26, 2025 15:32
neilalexander
neilalexander reviewed Apr 8, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting! Linter seems unhappy though, mind rebasing & taking a look?

@astmix
Copy link
Author

astmix commented Apr 8, 2025

Looks interesting! Linter seems unhappy though, mind rebasing & taking a look?

Fixed. The linter should pass now

@github-actions github-actions bot added the stale This issue has had no activity in a while label Jun 7, 2025
@astmix astmix requested a review from neilalexander July 15, 2025 14:05
@github-actions github-actions bot removed the stale This issue has had no activity in a while label Jul 16, 2025
neilalexander
neilalexander reviewed Jul 21, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for letting this sit for so long, overall looks good but could you rebase & then please fix the copyright years in the headers?

@astmix astmix force-pushed the testing/fuzz_tests branch from 3e55808 to 8166de1 Compare July 21, 2025 13:13
@astmix
Copy link
Author

astmix commented Jul 21, 2025

Apologies for letting this sit for so long, overall looks good but could you rebase & then please fix the copyright years in the headers?

No problem! Fixed

@neilalexander
Copy link
Member

Ahh, the sign-off check is failing because of the commit message, may be easier to squash the three commits down into one and then add the Signed-off-by: to the commit message once.

@astmix astmix force-pushed the testing/fuzz_tests branch from 8166de1 to e62e8cd Compare July 21, 2025 13:22
@astmix
Copy link
Author

astmix commented Jul 21, 2025

Ahh, the sign-off check is failing because of the commit message, may be easier to squash the three commits down into one and then add the Signed-off-by: to the commit message once.

yeah, my apologies for the interruption

Add fuzz tests
16a2a93 
Signed-off-by: Sergey Sobolev <seregasobolev96@gmail.com>
@astmix astmix force-pushed the testing/fuzz_tests branch from e62e8cd to 16a2a93 Compare July 21, 2025 13:27
neilalexander
neilalexander approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution! Will wire this up to our test suites soon.

@neilalexander neilalexander merged commit 06166db into nats-io:main Jul 21, 2025
23 checks passed
@neilalexander neilalexander mentioned this pull request Jul 24, 2025
Merged
@wallyqs wallyqs changed the title Add fuzz tests [ADDED] Add fuzz tests Jul 24, 2025
neilalexander added a commit that referenced this pull request Jul 25, 2025
@neilalexander
Cherry-picks for 2.11.7-RC.1 (#7098)
0b1e526 
Includes the following:

- #7031
- #7033
- #7034
- #7035
- #7036
- #7040
- #7043
- #7045
- #7047
- #7046
- #7050
- #7051
- #7052
- #7053
- #7061
- #7063
- #7064
- #7065
- #7066
- #7070
- #7072
- #7080
- #7026
- #6728
- #7074
- #7089
- #7095
- #7087
- #7094
- #7096
- #7099

Signed-off-by: Neil Twigg <neil@nats.io>
@astmix astmix mentioned this pull request Aug 4, 2025
Merged
neilalexander added a commit that referenced this pull request Aug 4, 2025
@neilalexander
Fuzz tests minor improvements (#7140)
5ab8ac2 
Minor changes related to fuzzing tests:

Fixed the years in the copyright file

The fuzz.go file is no longer needed since it was moved to
parser_fuzz_test.go in #6728

Signed-off-by: Sergey Sobolev <seregasobolev96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astmix @neilalexander