Remove Windows-specific default registry definitions #21100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @aaronlehmann! Should we revert #19891 and #19973 with that? |
|
@icecrime: I considered reverting those PRs as part of this one. I think the way they make the client check which default registry the daemon uses is still more correct than leaving it up to the client, even if it won't technically matter after this PR. There may be some backward compatibility scenarios where #19891 and #19973 are still helpful. The tradeoff is that those PRs introduced a bit more complexity. If simplifying the code is worth reintroducing the assumption that the client knows the correct default registry, I'm fine with reverting them. |
|
@aaronlehmann Not leaving the decision to the client SGTM, let's keep this code in. Thanks, LGTM. |
Going forward, Docker won't use a different default registry on Windows. This changes Windows to use the standard Docker Hub registry as the default registry. There is a plan in place to migrate existing images from the Windows registry to Hub's normal registry, in advance of the 1.11 release. In the mean time, images on the Windows registry can be accessed by prefixing them with `registry-win-tp3.docker.io/`. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
58da6f0 to
87535ca
Compare
|
LGTM |
calavera
added a commit
that referenced
this pull request
Mar 11, 2016
…egistry Remove Windows-specific default registry definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going forward, Docker won't use a different default registry on Windows.
This changes Windows to use the standard Docker Hub registry as the
default registry.
There is a plan in place to migrate existing images from the Windows
registry to Hub's normal registry, in advance of the 1.11 release. In
the mean time, images on the Windows registry can be accessed by
prefixing them with
registry-win-tp3.docker.io/.cc @dmp42 @friism @icecrime @jhowardmsft @jstarks