Skip to content

Enable cross-platforms login to Registry #19891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2016
Merged

Enable cross-platforms login to Registry #19891

merged 1 commit into from
Feb 2, 2016

Conversation

icecrime
Copy link
Contributor

@icecrime icecrime commented Feb 1, 2016

Use a daemon-defined Registry URL for docker login.

This allows a Windows client interacting with a Linux daemon to properly use the default Registry endpoint instead of the Windows specific one.

Fixes #18019.

Enable cross-platforms login to Registry
960710b 
Use a daemon-defined Registry URL for `docker login`. This allows a
Windows client interacting with a Linux daemon to properly use the
default Registry endpoint instead of the Windows specific one.

Signed-off-by: Arnaud Porterie <arnaud.porterie@docker.com>
@icecrime icecrime added this to the 1.10.0 milestone Feb 1, 2016
@tonistiigi
Copy link
Member

LGTM

1 similar comment
@tiborvass
Copy link
Contributor

LGTM

@vdemeester
Copy link
Member

LGTM 👼

@aaronlehmann
Copy link
Contributor

LGTM

1 similar comment
@lowenna
Copy link
Member

lowenna commented Feb 1, 2016

LGTM

@icecrime
Copy link
Contributor Author

icecrime commented Feb 1, 2016

Not sure about the failures on janky, docker-py-test seems ok locally:

=========================== short test summary info ============================
SKIP [1] tests/integration/image_test.py:216: Doesn't work inside a container - FIXME

==================== 101 passed, 1 skipped in 92.99 seconds ====================

I'll relaunch.

@thaJeztah
Copy link
Member

And DockerHubPullSuite.TestPullAllTagsFromCentralRegistry failed; https://jenkins.dockerproject.org/job/Docker-PRs/23293/console

21:26:27 Get https://registry-1.docker.io/v2/library/busybox/manifests/ubuntu-12.04: read tcp 172.17.0.2:48061->52.7.161.248:443: i/o timeout
21:26:27 , exit status 1

restarting

@friism
Copy link
Contributor

friism commented Feb 2, 2016

These may be related:

tiborvass added a commit that referenced this pull request Feb 2, 2016
@tiborvass
Merge pull request #19891 from icecrime/windows_login_issue
19eaa71 
Enable cross-platforms login to Registry
@tiborvass tiborvass merged commit 19eaa71 into moby:master Feb 2, 2016
@icecrime icecrime deleted the windows_login_issue branch February 2, 2016 00:50
This was referenced Feb 2, 2016
Closed
Closed
@friism
Copy link
Contributor

friism commented Feb 3, 2016

@icecrime @dmp42 so close...:

Username: friism4test
Password:
Email: friism+test@gmail.com
WARNING: login credentials saved in C:\Users\Michael Friis.DESKTOP-AAQL7UA.docker\config.json
Account created. Please use the confirmation link we sent to your e-mail to activate it.
PS C:\Windows\system32> docker logout
Not logged in to https://registry-win-tp3.docker.io/v1/
PS C:\Windows\system32>

@icecrime icecrime mentioned this pull request Feb 3, 2016
Merged
@thaJeztah thaJeztah mentioned this pull request Feb 15, 2016
Open
@rrarunan rrarunan mentioned this pull request Feb 22, 2016
Closed
@icecrime icecrime mentioned this pull request Mar 10, 2016
Merged
@thaJeztah thaJeztah mentioned this pull request Mar 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/distribution Image Distribution impact/changelog platform/windows
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
9 participants
@icecrime @tonistiigi @tiborvass @vdemeester @aaronlehmann @lowenna @thaJeztah @friism @GordonTheTurtle