Skip to content

Conversation

Aesthetikx
Copy link
Contributor

This commit 85e1961 and then 0872596 added a fair amount of the tags present in the HTML5 spec, but there are still some missing. The one I really wanted was <main>, but I figured I would finish the list. I added, as far as I could tell, the ones that were missing, as well as their custom attributes, if any.

🦊 🦊 🥓

@smtlaissezfaire smtlaissezfaire self-requested a review June 14, 2024 04:45
Copy link
Contributor

@smtlaissezfaire smtlaissezfaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the submission. Sorry for the super long delay into looking at this; this project hasn't really been on my radar for a while.

@smtlaissezfaire smtlaissezfaire merged commit a840271 into markaby:master Jun 14, 2024
@Aesthetikx
Copy link
Contributor Author

Haha all good, I'm glad it got in! Now I can continue working on my blog, this was a huge blocker for me 🤣 😎

@Aesthetikx Aesthetikx deleted the add_missing_html5_tags branch June 14, 2024 13:13
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 15, 2024
0.9.4 (2024-06-14)

* Earlopain - Fix compatibility with latest builder release #49

* github.com/markaby/markaby/pull/49

* Aesthetikx Add Missing HTML5 Tags #48 - github.com/markaby/markaby/pull/48

* MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50,
  github.com/markaby/markaby/pull/34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants