Small refactorings #34
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MrPowers - Thanks for the contribution. What advantage does this patch have over what's there already? What versions of ruby would this cut off? |
|
Thanks for the contribution! Going to merge #50 which is a rebased version. FYI define_singleton_method was introduced in ruby 1.9.1 - in 2009, so I'm pretty sure it's old enough for everyone. |
smtlaissezfaire
added a commit
that referenced
this pull request
Jun 14, 2024
Small refactorings (from #34)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jun 15, 2024
0.9.4 (2024-06-14) * Earlopain - Fix compatibility with latest builder release #49 * github.com/markaby/markaby/pull/49 * Aesthetikx Add Missing HTML5 Tags #48 - github.com/markaby/markaby/pull/48 * MrPowers - Small Refactorings - github.com/markaby/markaby/pull/50, github.com/markaby/markaby/pull/34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some minor changes to delete some unnecessary code. If you're open to these type of changes, I'd be happy to go through the entire codebase to add some tests and clean it up. I'm traveling in Vietnam at the moment, but will be looking for open source projects to work on when I get home in a couple of weeks. Thanks!