Skip to content

Detailed documentation on Load Problems #6529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 27, 2025
Merged

Detailed documentation on Load Problems #6529

merged 7 commits into from
Jun 27, 2025

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jun 24, 2025 •
edited
Loading

🚀 Pull Request

Description

Closes #6323

See the docs

To-do

  • More detail on the mechanics of LOAD_PROBLEMS
  • Consider the overlap between the new User Guide page and the detail in the LOAD_PROBLEMS docstring itself
  • Decide on an order for the sub-headings
  • Is the explanation section too much detail for the User Guide? (Is this another example of us missing Diataxis?)
  • Thank @ESadek-MO for the highly useful glossary page, allowing me to use the :term: directive

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (8a14a31) to head (405f2cc).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6529   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          90       90           
  Lines       23921    23922    +1     
  Branches     4461     4461           
=======================================
+ Hits        21500    21501    +1     
  Misses       1669     1669           
  Partials      752      752

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trexfeathers trexfeathers linked an issue Jun 25, 2025 that may be closed by this pull request
Common agreement on loading CF non-compliant NetCDF files #5165
Closed
@trexfeathers trexfeathers marked this pull request as ready for review June 25, 2025 16:23
ukmo-ccbunney
ukmo-ccbunney requested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new Iris's Philosophy page.
Just some small suggestions.

trexfeathers
trexfeathers commented Jun 27, 2025
View reviewed changes
Copy link
Contributor Author

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, have actioned your suggestions.

(I hope you're aware I'm not responsible for the Code Maintenance section - it was like that when I got here!)

@ukmo-ccbunney
Copy link
Contributor

Thanks, have actioned your suggestions.

(I hope you're aware I'm not responsible for the Code Maintenance section - it was like that when I got here!)

Ah yes, of course - I was straying a bit onto changes that were not yours (they show up of course as GH sees it as a new page).

ukmo-ccbunney
ukmo-ccbunney approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - I've reviewed the rest of the changes and it all looks good.
Great job! 💯
LTGM!

@ukmo-ccbunney ukmo-ccbunney merged commit 1f65369 into SciTools:main Jun 27, 2025
22 checks passed
ukmo-ccbunney added a commit to ukmo-ccbunney/iris that referenced this pull request Jun 27, 2025
@ukmo-ccbunney
Merge remote-tracking branch 'origin/mutli_coord_systems' into mutli_…
a6c8f48 
…coord_systems

* origin/mutli_coord_systems:
  Some do-nothing reminders about the next release (SciTools#6521)
  Detailed documentation on Load Problems (SciTools#6529)
  Save crs_wkt on netCDF save, take 2 (SciTools#6519)
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Jul 26, 2025
@trexfeathers trexfeathers deleted the tolerance_docs branch August 22, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukmo-ccbunney ukmo-ccbunney ukmo-ccbunney approved these changes

Assignees
No one assigned
Labels
Feature: NetCDF + CF-conventions Type: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document capturing of un-loadable NetCDF objects Common agreement on loading CF non-compliant NetCDF files
2 participants
@trexfeathers @ukmo-ccbunney