Skip to content

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jun 17, 2025

🚀 Pull Request

Description

Closes #4719, closes #6407

Targetting a feature branch as this won't make sense without #3388 as well.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Jun 17, 2025

I think @wjbenfold's commits are associated with an inactive email address. I might need to re-author these under my own name 🫨

@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

@trexfeathers
Copy link
Contributor Author

I think @wjbenfold's commits are associated with an inactive email address. I might need to re-author these under my own name 🫨

Alternatively @wjbenfold you could send me an alternative email address that IS associated with GitHub, and I can edit those commits (this would also require a CLA signature).

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.88%. Comparing base (3fe8169) to head (28fdf35).
Report is 1 commits behind head on FEATURE_wkt.

Additional details and impacted files
@@             Coverage Diff              @@
##           FEATURE_wkt    #6519   +/-   ##
============================================
  Coverage        89.87%   89.88%           
============================================
  Files               90       90           
  Lines            23908    23909    +1     
  Branches          4459     4459           
============================================
+ Hits             21487    21490    +3     
+ Misses            1669     1668    -1     
+ Partials           752      751    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trexfeathers
Copy link
Contributor Author

Ah, they're associated with my Met Office email. Use ... instead?

Super, that worked, thanks! I've never needed git filter-branch before 😅

I'm gonna delete your comment now to stop any bad actors scraping your email address.

@SciTools SciTools deleted a comment from wjbenfold Jun 18, 2025
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍
Just one query.

Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! LGTM 🚀

@ukmo-ccbunney ukmo-ccbunney merged commit d1d77aa into SciTools:FEATURE_wkt Jun 18, 2025
21 checks passed
ukmo-ccbunney added a commit to ukmo-ccbunney/iris that referenced this pull request Jun 27, 2025
…coord_systems

* origin/mutli_coord_systems:
  Some do-nothing reminders about the next release (SciTools#6521)
  Detailed documentation on Load Problems (SciTools#6529)
  Save crs_wkt on netCDF save, take 2 (SciTools#6519)
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Jul 17, 2025
@trexfeathers trexfeathers deleted the resurrect-wkt branch August 22, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants