-
Notifications
You must be signed in to change notification settings - Fork 296
Save crs_wkt on netCDF save, take 2 #6519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save crs_wkt on netCDF save, take 2 #6519
Conversation
I think @wjbenfold's commits are associated with an inactive email address. I might need to re-author these under my own name 🫨 |
Alternatively @wjbenfold you could send me an alternative email address that IS associated with GitHub, and I can edit those commits (this would also require a CLA signature). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_wkt #6519 +/- ##
============================================
Coverage 89.87% 89.88%
============================================
Files 90 90
Lines 23908 23909 +1
Branches 4459 4459
============================================
+ Hits 21487 21490 +3
+ Misses 1669 1668 -1
+ Partials 752 751 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d918cb7
to
28fdf35
Compare
Super, that worked, thanks! I've never needed I'm gonna delete your comment now to stop any bad actors scraping your email address. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Just one query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! LGTM 🚀
…coord_systems * origin/mutli_coord_systems: Some do-nothing reminders about the next release (SciTools#6521) Detailed documentation on Load Problems (SciTools#6529) Save crs_wkt on netCDF save, take 2 (SciTools#6519)
🚀 Pull Request
Description
Closes #4719, closes #6407
Targetting a feature branch as this won't make sense without #3388 as well.
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: