Add a text feature to quickplot #6333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6333 +/- ##
==========================================
+ Coverage 89.77% 89.78% +0.01%
==========================================
Files 90 90
Lines 23523 23548 +25
Branches 4390 4391 +1
==========================================
+ Hits 21118 21143 +25
Misses 1662 1662
Partials 743 743 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjlittle
requested changes
Feb 27, 2025
There was a problem hiding this comment.
@ESadek-MO LGTM
This supports the minimum behaviour with no customisation. That seems completely reasonable to me as a first step. We can always add that at a later date based on what users want. Suits the philosophy of quickplot 👍
Just a couple of minor suggestions to consider ...
bjlittle
reviewed
Feb 27, 2025
bjlittle
approved these changes
Feb 27, 2025
ukmo-ccbunney
added a commit
to ukmo-ccbunney/iris
that referenced
this pull request
Feb 28, 2025
* upstream/main: Faster dimension lookup for derived coordinates (SciTools#6337) Unpin dask 2 (SciTools#6342) added classification enums to qp (SciTools#6346) Add castable check for valid_range, valid_min, valid_max. (SciTools#6343) Pin Sphinx below 8.2 (SciTools#6344) Add a text feature to quickplot (SciTools#6333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
See #6247