Skip to content

Faster dimension lookup for derived coordinates #6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2025
Merged

Faster dimension lookup for derived coordinates #6337

merged 3 commits into from
Feb 28, 2025

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

This makes looking up the dimensions of derived coordinates faster by first looking if the metadata of the requested coordinate matches that of an AuxFactory instead of creating the derived coordinate and then comparing the metadata. Creating a derived coordinate is a relatively slow operation.

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (d103230) to head (deafaa6).
Report is 88 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6337   +/-   ##
=======================================
  Coverage   89.77%   89.78%           
=======================================
  Files          90       90           
  Lines       23523    23523           
  Branches     4390     4390           
=======================================
+ Hits        21118    21119    +1     
  Misses       1662     1662           
+ Partials      743      742    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela bouweandela added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Feb 26, 2025
@github-actions GitHub Actions
Copy link
Contributor

⏱️ Performance Benchmark Report: 5e00767

Performance shifts 
| Change   | Before [d1032300]    | After [5e00767d]    |   Ratio | Benchmark (Parameter)                                             |
|----------|----------------------|---------------------|---------|-------------------------------------------------------------------|
| -        | 119±0.7ms            | 83.4±0.9ms          |    0.7  | cube.CubeEquality.time_equality(False, False, 'coord_inequality') |
| -        | 120±1ms              | 82.9±3ms            |    0.69 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')  |
| -        | 206±2ms              | 172±5ms             |    0.83 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')   |
Full benchmark results 

Benchmarks that have improved:

| Change   | Before [d1032300]    | After [5e00767d]    |   Ratio | Benchmark (Parameter)                                             |
|----------|----------------------|---------------------|---------|-------------------------------------------------------------------|
| -        | 119±0.7ms            | 83.4±0.9ms          |    0.7  | cube.CubeEquality.time_equality(False, False, 'coord_inequality') |
| -        | 120±1ms              | 82.9±3ms            |    0.69 | cube.CubeEquality.time_equality(True, False, 'coord_inequality')  |
| -        | 206±2ms              | 172±5ms             |    0.83 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')   |

Benchmarks that have stayed the same:

| Change   | Before [d1032300]    | After [5e00767d]    | Ratio   | Benchmark (Parameter)                                                                       |
|----------|----------------------|---------------------|---------|---------------------------------------------------------------------------------------------|
|          | 58.7±0.5ms           | 59.5±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 59.3±0.4ms           | 60.2±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 203±5ms              | 203±1ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 202±3ms              | 204±2ms             | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 37.2±0.7ms           | 37.9±0.8ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 37.3±1ms             | 38.5±0.4ms          | 1.03    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 37.2±0.6ms           | 37.5±0.7ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 38.4±0.9ms           | 37.8±0.7ms          | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 51.3±0.7ms           | 51.2±1ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 50.6±0.3ms           | 52.3±0.7ms          | 1.03    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 136±2ms              | 137±2ms             | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 136±0.8ms            | 138±2ms             | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 55.2±0.7ms           | 56.0±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 55.7±0.5ms           | 56.6±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 62.2±0.6ms           | 62.8±0.9ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 63.6±1ms             | 63.7±1ms            | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 50.3±0.5ms           | 51.0±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 50.7±0.4ms           | 51.9±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.09±0.01s           | 1.09±0.01s          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.09±0.01s           | 1.10±0s             | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 492±9ms              | 511±10ms            | 1.04    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 501±7ms              | 513±10ms            | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 35.6±0.4ms           | 36.8±0.7ms          | 1.03    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 36.8±0.3ms           | 37.2±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 65.6±0.6ms           | 67.5±1ms            | 1.03    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 66.3±0.7ms           | 68.0±1ms            | 1.03    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 69.1±0.9ms           | 69.6±1ms            | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 69.4±0.5ms           | 70.7±1ms            | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 64.5±0.5ms           | 65.3±0.7ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 64.7±0.5ms           | 66.0±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 24.6±0.2ms           | 25.2±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 28.8±0.4ms           | 30.1±0.9ms          | 1.05    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 129±4ms              | 132±3ms             | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 145±2ms              | 146±3ms             | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 22.3±0.3ms           | 23.4±0.7ms          | 1.05    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 26.5±0.2ms           | 27.3±0.9ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 22.2±0.3ms           | 23.4±1ms            | 1.05    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 26.9±0.2ms           | 27.9±1ms            | 1.04    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 23.4±0.2ms           | 24.0±0.7ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 27.5±0.2ms           | 28.6±0.9ms          | 1.04    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 36.0±0.4ms           | 37.0±0.9ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 40.4±0.4ms           | 41.6±0.9ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 23.6±0.2ms           | 24.1±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 28.0±0.2ms           | 28.9±0.5ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 26.1±0.3ms           | 26.9±0.6ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 30.2±0.2ms           | 31.1±0.8ms          | 1.03    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 23.0±0.1ms           | 24.0±0.8ms          | 1.04    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 27.7±0.3ms           | 28.1±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 546±4ms              | 543±2ms             | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 545±4ms              | 555±3ms             | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 151±1ms              | 153±5ms             | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 164±0.7ms            | 167±5ms             | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 22.3±0.2ms           | 22.4±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 26.7±0.3ms           | 27.0±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 25.5±0.5ms           | 25.8±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 30.1±0.6ms           | 30.8±0.6ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 25.6±0.3ms           | 26.1±0.8ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 30.0±0.4ms           | 30.3±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 24.7±0.3ms           | 25.3±0.8ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 29.8±0.4ms           | 29.8±1ms            | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 92.7±1ms             | 93.8±1ms            | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 91.9±2ms             | 93.3±2ms            | 1.02    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 104±1ms              | 106±1ms             | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 105±0.7ms            | 106±1ms             | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 61.1±0.8ms           | 62.1±1ms            | 1.02    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 62.0±0.8ms           | 63.0±0.9ms          | 1.02    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 29.3±0.2ms           | 29.9±0.5ms          | 1.02    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 33.9±0.7ms           | 34.8±0.7ms          | 1.03    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 31.6±0.6ms           | 31.5±0.6ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 35.6±0.6ms           | 36.2±0.7ms          | 1.02    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 25.4±0.4ms           | 25.7±0.5ms          | 1.01    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 29.7±0.6ms           | 29.8±0.5ms          | 1.01    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 319±6ms              | 324±4ms             | 1.02    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 331±3ms              | 339±5ms             | 1.02    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.07±0.01ms          | 1.10±0.01ms         | 1.02    | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 381±3μs              | 384±5μs             | 1.01    | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 913±8μs              | 932±10μs            | 1.02    | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 560±5μs              | 562±10μs            | 1.00    | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 225±3ms              | 191±4ms             | 0.85    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 250±1ms              | 214±3ms             | 0.86    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.4±0.1μs           | 16.4±0.1μs          | 1.00    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 315±4ms              | 279±9ms             | 0.89    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 206±2ms              | 172±4ms             | 0.84    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 338±3ms              | 306±8ms             | 0.90    | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 16.4±0.2μs           | 16.6±0.2μs          | 1.01    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 227±3ms              | 190±4ms             | 0.84    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 252±3ms              | 219±5ms             | 0.87    | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 51.5±0.7μs           | 51.2±0.4μs          | 1.00    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 311±3ms              | 278±8ms             | 0.89    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 338±3ms              | 308±10ms            | 0.91    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 52.4±0.4μs           | 53.0±0.8μs          | 1.01    | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 797±2μs              | 800±3μs             | 1.00    | import_iris.Iris.time__concatenate                                                          |
|          | 183±2μs              | 183±1μs             | 1.00    | import_iris.Iris.time__constraints                                                          |
|          | 114±0.7μs            | 113±2μs             | 0.99    | import_iris.Iris.time__data_manager                                                         |
|          | 89.7±1μs             | 90.6±1μs            | 1.01    | import_iris.Iris.time__deprecation                                                          |
|          | 163±1μs              | 163±2μs             | 1.00    | import_iris.Iris.time__lazy_data                                                            |
|          | 905±6μs              | 906±6μs             | 1.00    | import_iris.Iris.time__merge                                                                |
|          | 72.6±0.9μs           | 73.1±0.7μs          | 1.01    | import_iris.Iris.time__representation                                                       |
|          | 596±3μs              | 611±10μs            | 1.02    | import_iris.Iris.time_analysis                                                              |
|          | 139±2μs              | 138±3μs             | 0.99    | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 106±0.8μs            | 105±1μs             | 0.99    | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 248±6μs              | 247±2μs             | 1.00    | import_iris.Iris.time_analysis__interpolation                                               |
|          | 192±2μs              | 189±2μs             | 0.99    | import_iris.Iris.time_analysis__regrid                                                      |
|          | 108±1μs              | 109±3μs             | 1.01    | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 136±1μs              | 141±2μs             | 1.03    | import_iris.Iris.time_analysis_calculus                                                     |
|          | 323±3μs              | 325±3μs             | 1.00    | import_iris.Iris.time_analysis_cartography                                                  |
|          | 91.5±0.6μs           | 89.9±2μs            | 0.98    | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 213±1μs              | 213±3μs             | 1.00    | import_iris.Iris.time_analysis_maths                                                        |
|          | 94.3±0.9μs           | 94.9±0.9μs          | 1.01    | import_iris.Iris.time_analysis_stats                                                        |
|          | 169±1μs              | 170±2μs             | 1.01    | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 311±3μs              | 313±4μs             | 1.00    | import_iris.Iris.time_aux_factory                                                           |
|          | 80.4±1μs             | 79.7±0.7μs          | 0.99    | import_iris.Iris.time_common                                                                |
|          | 159±1μs              | 160±2μs             | 1.00    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.37±0ms             | 1.37±0.01ms         | 1.00    | import_iris.Iris.time_common_metadata                                                       |
|          | 174±3μs              | 168±2μs             | 0.97    | import_iris.Iris.time_common_mixin                                                          |
|          | 1.19±0.02ms          | 1.18±0ms            | 0.98    | import_iris.Iris.time_common_resolve                                                        |
|          | 199±3μs              | 199±2μs             | 1.00    | import_iris.Iris.time_config                                                                |
|          | 127±3μs              | 126±2μs             | 0.99    | import_iris.Iris.time_coord_categorisation                                                  |
|          | 383±6μs              | 386±10μs            | 1.01    | import_iris.Iris.time_coord_systems                                                         |
|          | 767±9μs              | 764±6μs             | 1.00    | import_iris.Iris.time_coords                                                                |
|          | 640±5μs              | 647±20μs            | 1.01    | import_iris.Iris.time_cube                                                                  |
|          | 231±1μs              | 235±2μs             | 1.02    | import_iris.Iris.time_exceptions                                                            |
|          | 72.1±0.7μs           | 73.1±1μs            | 1.01    | import_iris.Iris.time_experimental                                                          |
|          | 177±1μs              | 178±3μs             | 1.00    | import_iris.Iris.time_fileformats                                                           |
|          | 248±8μs              | 252±9μs             | 1.02    | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.54±0.04ms          | 2.54±0.03ms         | 1.00    | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 75.6±0.6μs           | 75.3±2μs            | 1.00    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 112±0.9μs            | 113±2μs             | 1.01    | import_iris.Iris.time_fileformats_abf                                                       |
|          | 422±5μs              | 432±9μs             | 1.02    | import_iris.Iris.time_fileformats_cf                                                        |
|          | 4.77±0.03ms          | 4.79±0.1ms          | 1.00    | import_iris.Iris.time_fileformats_dot                                                       |
|          | 71.8±0.5μs           | 70.6±1μs            | 0.98    | import_iris.Iris.time_fileformats_name                                                      |
|          | 253±3μs              | 251±4μs             | 0.99    | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 111±0.8μs            | 113±3μs             | 1.01    | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 120±3μs              | 120±2μs             | 1.00    | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 208±3μs              | 208±3μs             | 1.00    | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 796±3μs              | 792±10μs            | 0.99    | import_iris.Iris.time_fileformats_pp                                                        |
|          | 180±2μs              | 179±6μs             | 1.00    | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 133±1μs              | 135±3μs             | 1.01    | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 544±10μs             | 545±20μs            | 1.00    | import_iris.Iris.time_fileformats_rules                                                     |
|          | 220±4μs              | 220±3μs             | 1.00    | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 80.4±0.5μs           | 79.9±1μs            | 0.99    | import_iris.Iris.time_fileformats_um                                                        |
|          | 158±2μs              | 158±1μs             | 1.00    | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 141±1μs              | 141±4μs             | 1.00    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 72.3±0.4μs           | 71.6±0.6μs          | 0.99    | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 78.7±0.6μs           | 77.4±0.4μs          | 0.98    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 942±4μs              | 946±10μs            | 1.01    | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 139±2μs              | 138±2μs             | 0.99    | import_iris.Iris.time_io                                                                    |
|          | 176±6μs              | 177±3μs             | 1.01    | import_iris.Iris.time_io_format_picker                                                      |
|          | 210±2μs              | 209±0.9μs           | 0.99    | import_iris.Iris.time_iris                                                                  |
|          | 128±2μs              | 126±3μs             | 0.98    | import_iris.Iris.time_iterate                                                               |
|          | 8.30±0.1ms           | 8.26±0.05ms         | 1.00    | import_iris.Iris.time_palette                                                               |
|          | 1.75±0.01ms          | 1.74±0.01ms         | 0.99    | import_iris.Iris.time_plot                                                                  |
|          | 102±1μs              | 101±0.5μs           | 1.00    | import_iris.Iris.time_quickplot                                                             |
|          | 2.16±0.03ms          | 2.18±0.03ms         | 1.01    | import_iris.Iris.time_std_names                                                             |
|          | 1.85±0.02ms          | 1.84±0.01ms         | 1.00    | import_iris.Iris.time_symbols                                                               |
|          | 102±2ms              | 101±0.9ms           | 0.99    | import_iris.Iris.time_tests                                                                 |
|          | 251±4μs              | 249±3μs             | 0.99    | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 5.01±0.04ms          | 4.99±0.06ms         | 0.99    | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 116±1μs              | 116±0.9μs           | 1.00    | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.68±0.01ms          | 2.70±0.02ms         | 1.01    | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.29±0.02ms          | 1.28±0ms            | 1.00    | import_iris.Iris.time_third_party_numpy                                                     |
|          | 166±3μs              | 167±4μs             | 1.00    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 97.7±1μs             | 97.5±3μs            | 1.00    | import_iris.Iris.time_time                                                                  |
|          | 334±4μs              | 342±6μs             | 1.02    | import_iris.Iris.time_util                                                                  |
|          | 69.7±0.9μs           | 71.1±0.5μs          | 1.02    | iterate.IZip.time_izip                                                                      |
|          | 10.1±0.08ms          | 10.2±0.2ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 15.3±0.2ms           | 15.3±0.6ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 10.1±0.06ms          | 10.3±0.1ms          | 1.01    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 10.2±0.2ms           | 10.3±0.07ms         | 1.01    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 12.8±0.3ms           | 12.8±0.2ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 10.3±0.1ms           | 10.2±0.09ms         | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.57±0.02s           | 1.56±0.02s          | 0.99    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 11.6±0.06ms          | 11.7±0.07ms         | 1.01    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.58±0.01s           | 1.60±0.01s          | 1.02    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.59±0.01s           | 1.59±0.01s          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 11.7±0.2ms           | 11.7±0.4ms          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.58±0.02s           | 1.58±0.03s          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 5.17±0.04ms          | 5.25±0.2ms          | 1.02    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 11.4±0.1ms           | 11.4±0.3ms          | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 5.21±0.07ms          | 5.34±0.07ms         | 1.02    | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 5.24±0.02ms          | 5.36±0.1ms          | 1.02    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 11.4±0.1ms           | 11.4±0.3ms          | 1.01    | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 5.20±0.03ms          | 5.28±0.08ms         | 1.02    | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 21.4±0.5ms           | 21.5±0.6ms          | 1.01    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 19.7±0.4ms           | 18.6±0.1ms          | 0.94    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 11.2±0.7ms           | 11.1±0.7ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 27.0±0.8ms           | 26.7±0.8ms          | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 68.5±1ms             | 68.2±0.8ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 26.3±2ms             | 26.3±0.3ms          | 1.00    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 546±7ms              | 547±3ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 2.68±0.1ms           | 2.69±0.1ms          | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 545±6ms              | 554±9ms             | 1.02    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 549±5ms              | 563±6ms             | 1.03    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 2.67±0.06ms          | 2.76±0.09ms         | 1.03    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 558±5ms              | 564±7ms             | 1.01    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.62±0.07ms          | 1.68±0.03ms         | 1.03    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 2.65±0.08ms          | 2.61±0.09ms         | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.62±0.05ms          | 1.63±0.07ms         | 1.01    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.64±0.05ms          | 1.68±0.06ms         | 1.02    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 2.79±0.07ms          | 2.77±0.1ms          | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.63±0.05ms          | 1.65±0.05ms         | 1.01    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 345±7ms              | 347±3ms             | 1.00    | load.ManyCubes.time_many_cube_load                                                          |
|          | 83.8±0.7ms           | 84.0±1ms            | 1.00    | load.ManyVars.time_many_var_load                                                            |
|          | 10.1±0.1ms           | 10.4±0.08ms         | 1.03    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 10.2±0.1ms           | 10.2±0.2ms          | 1.00    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.59±0.02s           | 1.61±0.01s          | 1.01    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.61±0.01s           | 1.63±0.01s          | 1.01    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 5.23±0.06ms          | 5.28±0.04ms         | 1.01    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 5.17±0.1ms           | 5.29±0.03ms         | 1.02    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 9.39±0.2ms           | 9.37±0.1ms          | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 6.15±0.02ms          | 6.17±0.02ms         | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.58±0.01s           | 1.59±0.02s          | 1.01    | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 577±4ms              | 576±9ms             | 1.00    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                  |
|          | 4.47±0.06ms          | 4.43±0.06ms         | 0.99    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 4.29±0.03ms          | 4.36±0.06ms         | 1.02    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 173±2ms              | 174±4ms             | 1.01    | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 14.8±0.2ms           | 14.7±0.5ms          | 1.00    | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 175±2ms              | 176±2ms             | 1.01    | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 33.7±0.6ms           | 34.0±0.5ms          | 1.01    | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 14.6±0.2ms           | 14.3±0.1ms          | 0.98    | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 33.7±0.3ms           | 34.2±0.3ms          | 1.02    | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 13.6±0.2ms           | 13.6±0.3ms          | 1.00    | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 48.5±0.7ms           | 48.1±1ms            | 0.99    | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 8.73±0.3ms           | 8.99±0.2ms          | 1.03    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 15.6±0.7ms           | 15.8±1ms            | 1.01    | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 13.4±0.2ms           | 13.5±0.8ms          | 1.01    | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 15.1±0.1ms           | 15.2±0.9ms          | 1.01    | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 8.64±0.1ms           | 8.86±0.5ms          | 1.03    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 11.6±0.3ms           | 11.4±1ms            | 0.98    | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 14.3±0.1ms           | 14.6±0.4ms          | 1.02    | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 59.3±0.7ms           | 59.0±2ms            | 0.99    | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 14.7±0.3ms           | 15.1±0.3ms          | 1.02    | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 16.8±0.4ms           | 17.8±0.8ms          | 1.06    | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 2.64±0.1ms           | 2.89±0.2ms          | 1.10    | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 3.64±0.3ms           | 4.32±0.4ms          | 1.18    | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 35.3±1ms             | 39.7±4ms            | 1.13    | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 775±10ms             | 778±10ms            | 1.00    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 445±6ms              | 451±8ms             | 1.01    | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 443±6ms              | 459±8ms             | 1.04    | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 109±0.3M             | 109±0.3M            | 1.00    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.3M             | 109±0.3M            | 1.00    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 49.2±0.3ms           | 50.6±1ms            | 1.03    | merge_concat.Merge.time_merge                                                               |
|          | 2.49±1M              | 2.07±1M             | ~0.83   | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 337±5ns              | 340±0.7ns           | 1.01    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 194±1ms              | 196±2ms             | 1.01    | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 651±1k               | 651±1k              | 1.00    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60.1±0M              | 60.1±0M             | 1.00    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 17.5±0.1ms           | 17.6±0.3ms          | 1.00    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)           |
|          | 19.9±0.2ms           | 20.3±0.3ms          | 1.02    | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 1.14±0M              | 1.14±0M             | 1.00    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 13±0M                | 13±0M               | 1.00    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 107±0.7ms            | 104±0.4ms           | 0.97    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 585±4ms              | 574±5ms             | 0.98    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.3±0.04M            | 1.27±0.04M          | 0.98    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.3±0.02M           | 96.3±0.02M          | 1.00    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 67.5±1ms             | 66.5±0.8ms          | 0.99    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 534±5ms              | 534±8ms             | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.19±0.01M           | 1.18±0.01M          | 0.99    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.01M           | 96.2±0.02M          | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998   | 216.01528499999998  | 1.00    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.81±0.08ms          | 6.88±0.07ms         | 1.01    | plot.AuxSort.time_aux_sort                                                                  |
|          | 77.0±4ms             | 77.0±2ms            | 1.00    | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M               | 136±3M              | 1.00    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 98.7±1ms             | 99.7±0.9ms          | 1.01    | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 47.4±0.6ms           | 48.5±1ms            | 1.02    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.06M            | 106±0.06M           | 1.00    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.02M            | 147±0.02M           | 1.00    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.38±0.07ms          | 4.37±0.06ms         | 1.00    | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 71.7±2ms             | 73.1±1ms            | 1.02    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 42.0±0.8ms           | 42.3±0.8ms          | 1.01    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 482±5ms              | 479±7ms             | 0.99    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 85.1±1ns             | 85.9±0.5ns          | 1.01    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 54.3±0.7ms           | 54.5±2ms            | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 85.1±2ns             | 88.0±0.8ns          | 1.03    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 421±5ms              | 418±2ms             | 0.99    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 30.6±0.1k            | 30.6±0.2k           | 1.00    | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.71±0.08M           | 1.71±0.2M           | 1.00    | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 30.6±0.1k            | 30.6±0.2k           | 1.00    | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 208±20M              | 225±20M             | 1.08    | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 41.5±0.3ms           | 42.1±0.3ms          | 1.01    | stats.PearsonR.time_lazy                                                                    |
|          | 8.69±0.2ms           | 8.84±0.2ms          | 1.02    | stats.PearsonR.time_real                                                                    |
|          | 24.6±1M              | 25±0.9M             | 1.02    | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M           | 18.4±0.01M          | 1.00    | stats.PearsonR.tracemalloc_real                                                             |
|          | 20.0±0.1ms           | 21.3±0.6ms          | 1.06    | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 66.8±0.4ms           | 67.6±0.7ms          | 1.01    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 17.6±0.02M           | 17.6±0.02M          | 1.00    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.01M           | 12.1±0.01M          | 1.00    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Generated by GHA run 13543776072

@bouweandela bouweandela marked this pull request as ready for review February 26, 2025 14:07
pp-mo
pp-mo approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pp-mo
Copy link
Member

pp-mo commented Feb 28, 2025

I see from your comment that this was sort-of in pursuit of something else, but it's an easy win so let's dispose of this one first !

@pp-mo pp-mo merged commit da199ee into SciTools:main Feb 28, 2025
21 checks passed
@pp-mo pp-mo mentioned this pull request Feb 28, 2025
Closed
ukmo-ccbunney added a commit to ukmo-ccbunney/iris that referenced this pull request Feb 28, 2025
@ukmo-ccbunney
Merge remote-tracking branch 'upstream/main' into varlen_str_type
1c34e42 
* upstream/main:
  Faster dimension lookup for derived coordinates (SciTools#6337)
  Unpin dask 2 (SciTools#6342)
  added classification enums to qp (SciTools#6346)
  Add castable check for valid_range, valid_min, valid_max. (SciTools#6343)
  Pin Sphinx below 8.2 (SciTools#6344)
  Add a text feature to quickplot (SciTools#6333)
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Closed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees
No one assigned
Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouweandela @pp-mo