Improve thread safety of setting paywalls preferred locale #2655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace @get:Synchronized with @volatile field for atomic reads/writes - Use minimal synchronized block only for the two-step update operation - Network calls happen outside synchronized block for better performance - Maintains thread safety while minimizing lock contention 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
tonidero
approved these changes
Sep 3, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2655 +/- ##
==========================================
- Coverage 78.10% 78.09% -0.02%
==========================================
Files 306 306
Lines 11482 11484 +2
Branches 1590 1590
==========================================
Hits 8968 8968
- Misses 1817 1819 +2
Partials 697 697 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JZDesign
approved these changes
Sep 3, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add preferred UI locale override for RevenueCat UI components (#2620) via Josh Holtz (@joshdholtz) ### 🔄 Other Changes * Improve thread safety of setting paywalls preferred locale (#2655) via Josh Holtz (@joshdholtz) * Remove validation for no packages on paywalls (#2653) via Josh Holtz (@joshdholtz) * Video Component Models (dark code) (#2646) via Jacob Rakidzich (@JZDesign) * [EXTERNAL] docs: fixed a typo on documentation about `Purchases.awaitPurchase` by @matteinn in #2593 (#2651) via Toni Rico (@tonidero) * Add warning with 9.x issues to all versions since 9.0.0 in CHANGELOG (#2650) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2647) via RevenueCat Git Bot (@RCGitBot) * Delete CLAUDE.md (#2648) via Cesar de la Vega (@vegaro) * MON-1193 flatten Transition JSON structure after chatting more thoroughly with team (#2641) via Jacob Rakidzich (@JZDesign) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve thread safety of setting preferred locale
Description
Make the variable
@Volatile