MON-1193 flatten Transition JSON structure after chatting more thoroughly with team #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Aug 28, 2025
purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/PaywallAnimation.kt
Show resolved
Hide resolved
purchases/src/main/kotlin/com/revenuecat/purchases/paywalls/components/PaywallAnimation.kt
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
+ Coverage 78.47% 78.52% +0.04%
==========================================
Files 305 304 -1
Lines 11354 11347 -7
Branches 1576 1576
==========================================
Hits 8910 8910
+ Misses 1753 1747 -6
+ Partials 691 690 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add preferred UI locale override for RevenueCat UI components (#2620) via Josh Holtz (@joshdholtz) ### 🔄 Other Changes * Improve thread safety of setting paywalls preferred locale (#2655) via Josh Holtz (@joshdholtz) * Remove validation for no packages on paywalls (#2653) via Josh Holtz (@joshdholtz) * Video Component Models (dark code) (#2646) via Jacob Rakidzich (@JZDesign) * [EXTERNAL] docs: fixed a typo on documentation about `Purchases.awaitPurchase` by @matteinn in #2593 (#2651) via Toni Rico (@tonidero) * Add warning with 9.x issues to all versions since 9.0.0 in CHANGELOG (#2650) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2647) via RevenueCat Git Bot (@RCGitBot) * Delete CLAUDE.md (#2648) via Cesar de la Vega (@vegaro) * MON-1193 flatten Transition JSON structure after chatting more thoroughly with team (#2641) via Jacob Rakidzich (@JZDesign) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Josh Holtz <me@joshholtz.com>
tonidero
pushed a commit
that referenced
this pull request
Sep 10, 2025
…ghly with team (#2641) <!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> - [x] If applicable, unit tests PR #2623 merged a day too soon. After Josh got back from a long weekend we had more time to chat. There are existing patterns in place to keep the json flat. Fortunately, if the code from that PR merges to production it will fallback to a Fade transition which is what we need for the immediate ask anyway. We also hashed out some details on what is optional. Flattened the json from : ```JSON "type": { "type": "some_type", "maybe_never_would_add_another_field": "some_value" } ``` to: ```JSON "type": "some_type", "maybe_never_would_add_another_field": "some_value" ``` and made the int values required values in the json <!-- Describe your changes in detail --> <!-- Please describe in detail how you tested your changes -->
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation
PR #2623 merged a day too soon. After Josh got back from a long weekend we had more time to chat. There are existing patterns in place to keep the json flat. Fortunately, if the code from that PR merges to production it will fallback to a Fade transition which is what we need for the immediate ask anyway. We also hashed out some details on what is optional.
Description
Flattened the json from :
to:
and made the int values required values in the json