Skip to content

Conversation

facumenzella
Copy link
Contributor

@facumenzella facumenzella commented Aug 26, 2025

Motivation

We want to be more explicit on how to edit the button text for the ScreenOffering.

ios

image

Description

  • Add button text to ScreenOffering

This comes already translated. For backwards compatibility, we default to the key used right now.

@facumenzella facumenzella changed the title Feat/support new key Add button_text to ScreenOffering Aug 26, 2025
@facumenzella facumenzella requested a review from vegaro August 26, 2025 15:45
@facumenzella facumenzella marked this pull request as ready for review August 26, 2025 15:45
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.47%. Comparing base (d3e6f0c) to head (5cbd87e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2638   +/-   ##
=======================================
  Coverage   78.47%   78.47%           
=======================================
  Files         305      305           
  Lines       11354    11354           
  Branches     1576     1576           
=======================================
  Hits         8910     8910           
  Misses       1753     1753           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@facumenzella facumenzella added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit 0ab1547 Aug 27, 2025
21 checks passed
@facumenzella facumenzella deleted the feat/support-new-key branch August 27, 2025 14:55
This was referenced Aug 27, 2025
tonidero pushed a commit that referenced this pull request Aug 28, 2025
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add option to disable automatic ID collection when setting attribution
network IDs at configuration time (#2643) via Toni Rico (@tonidero)
### 🐞 Bugfixes
* Handle payment pending errors when restoring properly (#2635) via Toni
Rico (@tonidero)

## RevenueCatUI SDK
### Paywallv2
#### ✨ New Features
* MON-1193 Support delayed close button (Component Transitions) (#2623)
via Jacob Rakidzich (@JZDesign)
#### 🐞 Bugfixes
* Fix PaywallDialog going over screen size on Android 35+ (#2642) via
Toni Rico (@tonidero)
### Customer Center
#### ✨ New Features
* Add button_text to ScreenOffering (#2638) via Facundo Menzella
(@facumenzella)

### 🔄 Other Changes
* Chore: Update detekt yml file (#2637) via Jacob Rakidzich (@JZDesign)
* Update CHANGELOG for version 8.23.0 release (#2636) via Toni Rico
(@tonidero)
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2633) via RevenueCat Git Bot (@RCGitBot)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants