Handle payment pending errors when restoring properly #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
- Coverage 78.47% 78.46% -0.01%
==========================================
Files 302 302
Lines 11303 11305 +2
Branches 1571 1571
==========================================
+ Hits 8870 8871 +1
- Misses 1745 1746 +1
Partials 688 688 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JZDesign
approved these changes
Aug 26, 2025
This was referenced Aug 27, 2025
tonidero
pushed a commit
that referenced
this pull request
Aug 28, 2025
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add option to disable automatic ID collection when setting attribution network IDs at configuration time (#2643) via Toni Rico (@tonidero) ### 🐞 Bugfixes * Handle payment pending errors when restoring properly (#2635) via Toni Rico (@tonidero) ## RevenueCatUI SDK ### Paywallv2 #### ✨ New Features * MON-1193 Support delayed close button (Component Transitions) (#2623) via Jacob Rakidzich (@JZDesign) #### 🐞 Bugfixes * Fix PaywallDialog going over screen size on Android 35+ (#2642) via Toni Rico (@tonidero) ### Customer Center #### ✨ New Features * Add button_text to ScreenOffering (#2638) via Facundo Menzella (@facumenzella) ### 🔄 Other Changes * Chore: Update detekt yml file (#2637) via Jacob Rakidzich (@JZDesign) * Update CHANGELOG for version 8.23.0 release (#2636) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2633) via RevenueCat Git Bot (@RCGitBot) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Sep 10, 2025
### Description Until now, if trying to restore a purchase with a payment pending error, the SDK returned an `UnknownBackendError` code. This should be returned instead with a `PaymentPendingError` code for proper handling. Note that restore errors return the error of the last post receipt with errors. If there were multiple errors, all might not be exposed right now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now, if trying to restore a purchase with a payment pending error, the SDK returned an
UnknownBackendErrorcode. This should be returned instead with aPaymentPendingErrorcode for proper handling.Note that restore errors return the error of the last post receipt with errors. If there were multiple errors, all might not be exposed right now.