-
Notifications
You must be signed in to change notification settings - Fork 82
Fail configure call if using test api key in release builds #2590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…efix at that point
…upport-test-store
…estStoreProductConverter.kt Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
…g posting receipt
…at/purchases-android into support-test-store
…upport-test-store
…upport-test-store
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
==========================================
- Coverage 78.28% 78.28% -0.01%
==========================================
Files 299 299
Lines 11043 11052 +9
Branches 1535 1537 +2
==========================================
+ Hits 8645 8652 +7
- Misses 1726 1727 +1
- Partials 672 673 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just a suggestion.
purchases/src/main/kotlin/com/revenuecat/purchases/PurchasesFactory.kt
Outdated
Show resolved
Hide resolved
**This is an automatic release.** ## RevenueCat SDK ### 📦 Dependency Updates * [RENOVATE] Update dependency gradle to v9 (#2589) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### Customer Center #### ✨ New Features * Show a subscribe button in customer center when there are no subscriptions (#2596) via Facundo Menzella (@facumenzella) #### 🐞 Bugfixes * Fix title and price of non-Google purchases in Customer Center (#2576) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2598) via RevenueCat Git Bot (@RCGitBot) * Add alias users backend call (#2594) via Toni Rico (@tonidero) * Rename TestStore to SimulatedStore (#2591) via Toni Rico (@tonidero) * Fail configure call if using test api key in release builds (#2590) via Toni Rico (@tonidero) * Support test store (#2554) via Toni Rico (@tonidero) * Fix insets in Paywall Tester (#2584) via Cesar de la Vega (@vegaro) * Add 8.22.1 to CHANGELOG (#2582) via Toni Rico (@tonidero) * Add warning on V9 CHANGELOG (#2586) via Toni Rico (@tonidero) * Change metalava job to diff dump generated dump files (#2585) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
### Description Android equivalent of RevenueCat/purchases-ios#5453 This PR introduces a crash at runtime if the app is running on release (on a debuggable process) when configuring the SDK with a Test Store API Key. Debug builds are unaffected. --------- Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
Description
Android equivalent of RevenueCat/purchases-ios#5453
This PR introduces a crash at runtime if the app is running on release (on a debuggable process) when configuring the SDK with a Test Store API Key. Debug builds are unaffected.