Skip to content

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Aug 5, 2025

Description

Android equivalent of RevenueCat/purchases-ios#5453

This PR introduces a crash at runtime if the app is running on release (on a debuggable process) when configuring the SDK with a Test Store API Key. Debug builds are unaffected.

tonidero and others added 30 commits July 22, 2025 13:08
…estStoreProductConverter.kt

Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
…at/purchases-android into support-test-store
@tonidero tonidero marked this pull request as ready for review August 5, 2025 10:32
@tonidero tonidero requested a review from a team August 5, 2025 10:33
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.28%. Comparing base (75cd9dc) to head (6c7fd7a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...otlin/com/revenuecat/purchases/PurchasesFactory.kt 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   78.28%   78.28%   -0.01%     
==========================================
  Files         299      299              
  Lines       11043    11052       +9     
  Branches     1535     1537       +2     
==========================================
+ Hits         8645     8652       +7     
- Misses       1726     1727       +1     
- Partials      672      673       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Just a suggestion.

Base automatically changed from support-test-store to main August 5, 2025 11:54
@tonidero tonidero enabled auto-merge August 5, 2025 12:34
@tonidero tonidero added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit c464dfa Aug 5, 2025
20 checks passed
@tonidero tonidero deleted the crash-app-test-store-release branch August 5, 2025 13:02
This was referenced Aug 13, 2025
tonidero pushed a commit that referenced this pull request Aug 14, 2025
**This is an automatic release.**

## RevenueCat SDK
### 📦 Dependency Updates
* [RENOVATE] Update dependency gradle to v9 (#2589) via RevenueCat Git
Bot (@RCGitBot)

## RevenueCatUI SDK
### Customer Center
#### ✨ New Features
* Show a subscribe button in customer center when there are no
subscriptions (#2596) via Facundo Menzella (@facumenzella)
#### 🐞 Bugfixes
* Fix title and price of non-Google purchases in Customer Center (#2576)
via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2598) via RevenueCat Git Bot (@RCGitBot)
* Add alias users backend call (#2594) via Toni Rico (@tonidero)
* Rename TestStore to SimulatedStore (#2591) via Toni Rico (@tonidero)
* Fail configure call if using test api key in release builds (#2590)
via Toni Rico (@tonidero)
* Support test store (#2554) via Toni Rico (@tonidero)
* Fix insets in Paywall Tester (#2584) via Cesar de la Vega (@vegaro)
* Add 8.22.1 to CHANGELOG (#2582) via Toni Rico (@tonidero)
* Add warning on V9 CHANGELOG (#2586) via Toni Rico (@tonidero)
* Change metalava job to diff dump generated dump files (#2585) via Toni
Rico (@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero added a commit that referenced this pull request Aug 25, 2025
### Description
Android equivalent of
RevenueCat/purchases-ios#5453

This PR introduces a crash at runtime if the app is running on release
(on a debuggable process) when configuring the SDK with a Test Store API
Key. Debug builds are unaffected.

---------

Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
@tonidero tonidero mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants