Skip to content

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Aug 1, 2025

Description

The metalava check jobs have been failing for a while, giving success even though there were changes in the api files. This PR changes to not use the check jobs, and instead always dump the api, and check git for changes.

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (f9edf9e) to head (eb420c9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2585   +/-   ##
=======================================
  Coverage   78.64%   78.64%           
=======================================
  Files         296      296           
  Lines       10888    10888           
  Branches     1520     1520           
=======================================
  Hits         8563     8563           
  Misses       1663     1663           
  Partials      662      662           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonidero tonidero marked this pull request as ready for review August 1, 2025 13:48
@tonidero tonidero requested a review from a team August 1, 2025 13:48
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@tonidero tonidero added this pull request to the merge queue Aug 1, 2025
Merged via the queue into main with commit 0f2efb6 Aug 1, 2025
20 checks passed
@tonidero tonidero deleted the make-metalava-job-diff-api-dumps branch August 1, 2025 16:50
This was referenced Aug 13, 2025
tonidero pushed a commit that referenced this pull request Aug 14, 2025
**This is an automatic release.**

## RevenueCat SDK
### 📦 Dependency Updates
* [RENOVATE] Update dependency gradle to v9 (#2589) via RevenueCat Git
Bot (@RCGitBot)

## RevenueCatUI SDK
### Customer Center
#### ✨ New Features
* Show a subscribe button in customer center when there are no
subscriptions (#2596) via Facundo Menzella (@facumenzella)
#### 🐞 Bugfixes
* Fix title and price of non-Google purchases in Customer Center (#2576)
via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2598) via RevenueCat Git Bot (@RCGitBot)
* Add alias users backend call (#2594) via Toni Rico (@tonidero)
* Rename TestStore to SimulatedStore (#2591) via Toni Rico (@tonidero)
* Fail configure call if using test api key in release builds (#2590)
via Toni Rico (@tonidero)
* Support test store (#2554) via Toni Rico (@tonidero)
* Fix insets in Paywall Tester (#2584) via Cesar de la Vega (@vegaro)
* Add 8.22.1 to CHANGELOG (#2582) via Toni Rico (@tonidero)
* Add warning on V9 CHANGELOG (#2586) via Toni Rico (@tonidero)
* Change metalava job to diff dump generated dump files (#2585) via Toni
Rico (@tonidero)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero added a commit that referenced this pull request Aug 25, 2025
### Description
The metalava check jobs have been failing for a while, giving success
even though there were changes in the api files. This PR changes to not
use the check jobs, and instead always dump the api, and check git for
changes.
@tonidero tonidero mentioned this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants