-
Notifications
You must be signed in to change notification settings - Fork 85
Change metalava job to diff dump generated dump files #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+10
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
=======================================
Coverage 78.64% 78.64%
=======================================
Files 296 296
Lines 10888 10888
Branches 1520 1520
=======================================
Hits 8563 8563
Misses 1663 1663
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit 4156f0d.
ajpallares
approved these changes
Aug 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
This was referenced Aug 13, 2025
tonidero
pushed a commit
that referenced
this pull request
Aug 14, 2025
**This is an automatic release.** ## RevenueCat SDK ### 📦 Dependency Updates * [RENOVATE] Update dependency gradle to v9 (#2589) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### Customer Center #### ✨ New Features * Show a subscribe button in customer center when there are no subscriptions (#2596) via Facundo Menzella (@facumenzella) #### 🐞 Bugfixes * Fix title and price of non-Google purchases in Customer Center (#2576) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2598) via RevenueCat Git Bot (@RCGitBot) * Add alias users backend call (#2594) via Toni Rico (@tonidero) * Rename TestStore to SimulatedStore (#2591) via Toni Rico (@tonidero) * Fail configure call if using test api key in release builds (#2590) via Toni Rico (@tonidero) * Support test store (#2554) via Toni Rico (@tonidero) * Fix insets in Paywall Tester (#2584) via Cesar de la Vega (@vegaro) * Add 8.22.1 to CHANGELOG (#2582) via Toni Rico (@tonidero) * Add warning on V9 CHANGELOG (#2586) via Toni Rico (@tonidero) * Change metalava job to diff dump generated dump files (#2585) via Toni Rico (@tonidero) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
### Description The metalava check jobs have been failing for a while, giving success even though there were changes in the api files. This PR changes to not use the check jobs, and instead always dump the api, and check git for changes.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The metalava check jobs have been failing for a while, giving success even though there were changes in the api files. This PR changes to not use the check jobs, and instead always dump the api, and check git for changes.