PaywallActivityLauncher: Add edgeToEdge parameter to display paywall in full screen
#2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…play paywall in full screen
tonidero
commented
Jul 15, 2025
| @@ -52,18 +52,22 @@ class PaywallActivityLauncher(resultCaller: ActivityResultCaller, resultHandler: | |||
| * will be used. Only available for original template paywalls. Ignored for v2 Paywalls. | |||
| * @param shouldDisplayDismissButton Whether to display the dismiss button in the paywall. | |||
| * Only available for original template paywalls. Ignored for v2 Paywalls. | |||
| * @param shouldDisplayEdgeToEdge Whether to display the paywall in edge-to-edge mode. | |||
| * Default is true for Android 16+, false otherwise. | |||
There was a problem hiding this comment.
I was doubting whether it's worth to default to the same across android versions... But I think we shouldn't cause a breaking change in older android versions.
tonidero
commented
Jul 15, 2025
| import android.os.Parcelable | ||
| import com.revenuecat.purchases.ui.revenuecatui.fonts.ParcelizableFontProvider | ||
| import com.revenuecat.purchases.ui.revenuecatui.fonts.PaywallFontFamily | ||
| import com.revenuecat.purchases.ui.revenuecatui.fonts.TypographyType | ||
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| internal const val DEFAULT_DISPLAY_DISMISS_BUTTON = true | ||
| internal val defaultDisplayEdgeToEdge = Build.VERSION.SDK_INT >= Build.VERSION_CODES.VANILLA_ICE_CREAM |
There was a problem hiding this comment.
I was actually thinking about this default... I changed it to also use edge to edge on android 35+, since that's the default starting on that version.
JayShortway
approved these changes
Jul 15, 2025
...src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/activity/PaywallActivityLauncher.kt
Outdated
Show resolved
Hide resolved
scripts/api-dump.sh
Outdated
There was a problem hiding this comment.
chmod changes I guess? Was this necessary on your machine? (You can run this script in Android Studio via the run configuration.)
There was a problem hiding this comment.
Yeah had to add extra permissions to be able to run it from terminal (didn't try to run from AS, thanks for the tip!)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 286 286
Lines 10572 10572
Branches 1485 1485
=======================================
Hits 8239 8239
Misses 1687 1687
Partials 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shouldDisplayEdgeToEdge parameter to display paywall in full screenedgeToEdge parameter to display paywall in full screen
This was referenced Jul 16, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
**This is an automatic release.** ## RevenueCat SDK ### Virtual Currency #### ✨ New Features * Virtual Currency Support (#2519) via Will Taylor (@fire-at-will) ## RevenueCatUI SDK ### Paywallv2 #### ✨ New Features * PaywallActivityLauncher: Add `edgeToEdge` parameter to display paywall in full screen (#2530) via Toni Rico (@tonidero) #### 🐞 Bugfixes * Remove logic to avoid repurchasing already subscribed products (#2492) via Toni Rico (@tonidero) ### 🔄 Other Changes * Dont run VC tests on load shedder integration tests (#2538) via Will Taylor (@fire-at-will) * Introduces `CompatComposeView` to handle scenarios where the view tree is not set up (#2527) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
…l in full screen (#2530) ### Description We currently were not supporting edge to edge in paywalls when using the `launch` and `launchIfNeeded` APIs. This adds a new parameter that allows to display it in edgeToEdge mode, or not. The default will be true for Android 15+ and false otherwise.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently were not supporting edge to edge in paywalls when using the
launchandlaunchIfNeededAPIs. This adds a new parameter that allows to display it in edgeToEdge mode, or not.The default will be true for Android 15+ and false otherwise.