Dont run VC tests on load shedder integration tests #2538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5986977.
tonidero
approved these changes
Jul 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2538 +/- ##
=======================================
Coverage 78.23% 78.23%
=======================================
Files 291 291
Lines 10772 10772
Branches 1504 1504
=======================================
Hits 8428 8428
Misses 1692 1692
Partials 652 652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
**This is an automatic release.** ## RevenueCat SDK ### Virtual Currency #### ✨ New Features * Virtual Currency Support (#2519) via Will Taylor (@fire-at-will) ## RevenueCatUI SDK ### Paywallv2 #### ✨ New Features * PaywallActivityLauncher: Add `edgeToEdge` parameter to display paywall in full screen (#2530) via Toni Rico (@tonidero) #### 🐞 Bugfixes * Remove logic to avoid repurchasing already subscribed products (#2492) via Toni Rico (@tonidero) ### 🔄 Other Changes * Dont run VC tests on load shedder integration tests (#2538) via Will Taylor (@fire-at-will) * Introduces `CompatComposeView` to handle scenarios where the view tree is not set up (#2527) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
pushed a commit
that referenced
this pull request
Aug 25, 2025
### Description We were running virtual currency integration tests both with and without the load shedder. However, the load shedder doesn't currently support virtual currencies, so these tests were failing when run for the load shedder integration test app. This PR updates the integration tests so that the virtual currency integration tests don't run for the load shedder integration tests app. ### Implementation Details We are able to accomplish this by: - When we're running integration tests through the integration tests app, fastlane sets the `IS_RUNNING_LOAD_SHEDDER_INTEGRATION_TESTS` string to `true` in `Constants.kt`. - There's a new function `BasePurchasesIntegrationTest.isRunningLoadShedderIntegrationTests`, that tests can use to determine if they're running in the load shedder integration test app. ### Testing I manually forced the integration tests to run on this PR, and both the regular and load shedder integration tests passed in Firebase
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were running virtual currency integration tests both with and without the load shedder. However, the load shedder doesn't currently support virtual currencies, so these tests were failing when run for the load shedder integration test app. This PR updates the integration tests so that the virtual currency integration tests don't run for the load shedder integration tests app.
Implementation Details
We are able to accomplish this by:
IS_RUNNING_LOAD_SHEDDER_INTEGRATION_TESTSstring totrueinConstants.kt.BasePurchasesIntegrationTest.isRunningLoadShedderIntegrationTests, that tests can use to determine if they're running in the load shedder integration test app.Testing
I manually forced the integration tests to run on this PR, and both the regular and load shedder integration tests passed in Firebase