Make PaywallActivity not consume insets in Android 16+ #2520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
added a commit
that referenced
this pull request
Jul 15, 2025
### Description This updates the android orb and the tag we use for our jobs. Which will allow us to have access to the latest android SDKs and fix tests in #2520
📸 Snapshot Test648 unchanged
🛸 Powered by Emerge Tools |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 286 286
Lines 10572 10572
Branches 1485 1485
=======================================
Hits 8239 8239
Misses 1687 1687
Partials 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
commented
Jul 15, 2025
| @@ -27,7 +27,7 @@ aliases: | |||
| executor: | |||
| name: android/android_docker | |||
| resource_class: xlarge | |||
| tag: 2024.04.1 | |||
| tag: 2025.04.1 | |||
There was a problem hiding this comment.
I missed updating the tag in #2521
| @@ -56,15 +57,15 @@ internal fun Bitmap.blur(context: Context, radius: Float, scaleDown: Boolean = t | |||
| script.setInput(input) | |||
| script.forEach(output) | |||
|
|
|||
| val blurredBitmap = Bitmap.createBitmap(bitmap.width, bitmap.height, config) | |||
| val blurredBitmap = config?.let { createBitmap(bitmap.width, bitmap.height, it) } | |||
There was a problem hiding this comment.
This is also part of #2525
tonidero
pushed a commit
that referenced
this pull request
Jul 15, 2025
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix upgrades/downgrades after BC8 update (#2532) via Toni Rico (@tonidero) ### 📦 Dependency Updates * [RENOVATE] Update build-dependencies (#2515) via RevenueCat Git Bot (@RCGitBot) * [RENOVATE] Update build-dependencies (#2472) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * Make PaywallActivity not consume insets in Android 16+ (#2520) via Toni Rico (@tonidero) ### 🔄 Other Changes * Add CLAUDE.md (#2522) via Cesar de la Vega (@vegaro) * Update kotlin version in README (#2524) via Cesar de la Vega (@vegaro) * Increase compile/target SDK version to 35 (#2525) via Toni Rico (@tonidero) * Fix snapshot deployment (#2526) via Toni Rico (@tonidero) * Update CircleCI android orb (#2521) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2517) via RevenueCat Git Bot (@RCGitBot) * Improve v9 migration docs (#2514) via Toni Rico (@tonidero) * Bump AGP to 8.10.1 and Gradle to 8.14.2 (#2440) via Jaewoong Eum (@skydoves) * Fixes compilation of the CEC sample app. (#2512) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
### Description This updates the android orb and the tag we use for our jobs. Which will allow us to have access to the latest android SDKs and fix tests in #2520
tonidero
added a commit
that referenced
this pull request
Aug 25, 2025
### Description This makes it so we don't consume insets in paywalls in Android 16+. Starting on Android 16+, by default apps will go edge to edge. We already consume insets correctly within the paywall as needed, but the activity was actually consuming those insets before that. A better fix might be to add an option to enable/disable this consumption, while keeping the current behavior in Android < 16 but changing it for android 16+. This is a short term fix for now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes it so we don't consume insets in paywalls in Android 16+. Starting on Android 16+, by default apps will go edge to edge. We already consume insets correctly within the paywall as needed, but the activity was actually consuming those insets before that.
A better fix might be to add an option to enable/disable this consumption, while keeping the current behavior in Android < 16 but changing it for android 16+. This is a short term fix for now.