Skip to content

Conversation

skydoves
Copy link
Member

Description

Bump AGP to 8.10.1 and Gradle to 8.14.2.

@skydoves skydoves requested a review from a team June 13, 2025 00:15
@skydoves skydoves self-assigned this Jun 13, 2025
@skydoves skydoves added the dependencies Pull requests that update a dependency file label Jun 13, 2025
Copy link
Member

@JayShortway JayShortway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This comment has nothing to do with this file 😄)

There seem to be some Kotlin version issues on CI, but I'm not sure what's happening at first glance. Especially confusing since some CI jobs work fine. Do the fastlane/gradle commands (in the failing CI jobs) work locally for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah that's interesting not sure why either. That looks like the same issue when trying to add a dependency that's compiled with another version of kotlin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm interesting... I actually tried upgrading AGP to 8.9.1 here but had issues because of the databinding library... but this seems like a separate error. We should figure this out in case we need to do anything for the next major once BC8 comes out.

@tonidero
Copy link
Contributor

@skydoves would you mind updating this PR to the latest main? I believe it should work now after #2493

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (1df5752) to head (2c07a67).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2440   +/-   ##
=======================================
  Coverage   78.34%   78.34%           
=======================================
  Files         286      286           
  Lines       10514    10514           
  Branches     1485     1485           
=======================================
  Hits         8237     8237           
  Misses       1631     1631           
  Partials      646      646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Seems to be working now 🙌. Not sure if we want to take the chance to upgrade AGP to the latest... But otherwise, I think we can merge this!

@tonidero tonidero mentioned this pull request Jul 10, 2025
@JayShortway
Copy link
Member

@tonidero Let's merge this! We can merge the Renovate one right after: #2472.

@JayShortway JayShortway added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 247a399 Jul 10, 2025
14 checks passed
@JayShortway JayShortway deleted the gradle/8.10.1 branch July 10, 2025 18:42
tonidero pushed a commit that referenced this pull request Jul 15, 2025
**This is an automatic release.**

## RevenueCat SDK
### 🐞 Bugfixes
* Fix upgrades/downgrades after BC8 update (#2532) via Toni Rico
(@tonidero)
### 📦 Dependency Updates
* [RENOVATE] Update build-dependencies (#2515) via RevenueCat Git Bot
(@RCGitBot)
* [RENOVATE] Update build-dependencies (#2472) via RevenueCat Git Bot
(@RCGitBot)

## RevenueCatUI SDK
### Paywallv2
#### 🐞 Bugfixes
* Make PaywallActivity not consume insets in Android 16+ (#2520) via
Toni Rico (@tonidero)

### 🔄 Other Changes
* Add CLAUDE.md (#2522) via Cesar de la Vega (@vegaro)
* Update kotlin version in README (#2524) via Cesar de la Vega (@vegaro)
* Increase compile/target SDK version to 35 (#2525) via Toni Rico
(@tonidero)
* Fix snapshot deployment (#2526) via Toni Rico (@tonidero)
* Update CircleCI android orb (#2521) via Toni Rico (@tonidero)
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2517) via RevenueCat Git Bot (@RCGitBot)
* Improve v9 migration docs (#2514) via Toni Rico (@tonidero)
* Bump AGP to 8.10.1 and Gradle to 8.14.2 (#2440) via Jaewoong Eum
(@skydoves)
* Fixes compilation of the CEC sample app. (#2512) via JayShortway
(@JayShortway)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
tonidero pushed a commit that referenced this pull request Aug 25, 2025
### Description

Bump AGP to 8.10.1 and Gradle to 8.14.2.
@tonidero tonidero mentioned this pull request Aug 25, 2025
tonidero added a commit that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants