-
Notifications
You must be signed in to change notification settings - Fork 86
Bump AGP to 8.10.1 and Gradle to 8.14.2 #2440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This comment has nothing to do with this file 😄)
There seem to be some Kotlin version issues on CI, but I'm not sure what's happening at first glance. Especially confusing since some CI jobs work fine. Do the fastlane/gradle commands (in the failing CI jobs) work locally for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm yeah that's interesting not sure why either. That looks like the same issue when trying to add a dependency that's compiled with another version of kotlin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm interesting... I actually tried upgrading AGP to 8.9.1 here but had issues because of the databinding library... but this seems like a separate error. We should figure this out in case we need to do anything for the next major once BC8 comes out.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
=======================================
Coverage 78.34% 78.34%
=======================================
Files 286 286
Lines 10514 10514
Branches 1485 1485
=======================================
Hits 8237 8237
Misses 1631 1631
Partials 646 646 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Seems to be working now 🙌. Not sure if we want to take the chance to upgrade AGP to the latest... But otherwise, I think we can merge this!
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * Fix upgrades/downgrades after BC8 update (#2532) via Toni Rico (@tonidero) ### 📦 Dependency Updates * [RENOVATE] Update build-dependencies (#2515) via RevenueCat Git Bot (@RCGitBot) * [RENOVATE] Update build-dependencies (#2472) via RevenueCat Git Bot (@RCGitBot) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * Make PaywallActivity not consume insets in Android 16+ (#2520) via Toni Rico (@tonidero) ### 🔄 Other Changes * Add CLAUDE.md (#2522) via Cesar de la Vega (@vegaro) * Update kotlin version in README (#2524) via Cesar de la Vega (@vegaro) * Increase compile/target SDK version to 35 (#2525) via Toni Rico (@tonidero) * Fix snapshot deployment (#2526) via Toni Rico (@tonidero) * Update CircleCI android orb (#2521) via Toni Rico (@tonidero) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2517) via RevenueCat Git Bot (@RCGitBot) * Improve v9 migration docs (#2514) via Toni Rico (@tonidero) * Bump AGP to 8.10.1 and Gradle to 8.14.2 (#2440) via Jaewoong Eum (@skydoves) * Fixes compilation of the CEC sample app. (#2512) via JayShortway (@JayShortway) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
### Description Bump AGP to 8.10.1 and Gradle to 8.14.2.
Description
Bump AGP to 8.10.1 and Gradle to 8.14.2.