Skip to content

Conversation

tonidero
Copy link
Contributor

@tonidero tonidero commented Jul 9, 2025

This reverts commit 2270d6a.

We want to make a release with some fixes before we're actually ready for the major. This reverts this PR so we can make that release before actually bumping the major.

@tonidero tonidero requested a review from a team July 9, 2025 16:43
@tonidero tonidero mentioned this pull request Jul 9, 2025
@tonidero tonidero enabled auto-merge July 9, 2025 16:51
@tonidero tonidero added this pull request to the merge queue Jul 9, 2025
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

Attention: Patch coverage is 82.82209% with 28 lines in your changes missing coverage. Please review.

Project coverage is 78.73%. Comparing base (ec097c2) to head (b4a3b2a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hases/google/usecase/QueryProductDetailsUseCase.kt 60.00% 5 Missing and 3 partials ⚠️
.../com/revenuecat/purchases/google/BillingWrapper.kt 91.07% 5 Missing ⚠️
...ases/google/usecase/QueryPurchaseHistoryUseCase.kt 90.47% 3 Missing and 1 partial ⚠️
...ecat/purchases/NoCoreLibraryDesugaringException.kt 0.00% 3 Missing ⚠️
...urchases/common/purchaseHistoryRecordExtensions.kt 62.50% 2 Missing and 1 partial ⚠️
...n/kotlin/com/revenuecat/purchases/google/errors.kt 40.00% 1 Missing and 2 partials ⚠️
...n/com/revenuecat/purchases/amazon/AmazonBilling.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   78.35%   78.73%   +0.38%     
==========================================
  Files         286      289       +3     
  Lines       10439    10526      +87     
  Branches     1500     1509       +9     
==========================================
+ Hits         8179     8288     +109     
+ Misses       1614     1590      -24     
- Partials      646      648       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonidero tonidero removed this pull request from the merge queue due to a manual request Jul 9, 2025
@tonidero tonidero merged commit 34c61a3 into main Jul 9, 2025
14 checks passed
@tonidero tonidero deleted the revert-bc8-migration branch July 9, 2025 17:17
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2025
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* feat(purchases): Add setPostHogUserId() method to Purchases API
(#2495) via Hussain Mustafa (@hussain-mustafa990)
### 🐞 Bugfixes
* Improves button progress indicator size calculation. (#2485) via
JayShortway (@JayShortway)

### 🔄 Other Changes
* Revert "BC8 migration (#2477)" (#2501) via Toni Rico (@tonidero)
* Add codelab instructions on README file (#2489) via Jaewoong Eum
(@skydoves)
* Use collectAsStateWithLifecycle instead of collectAsState in Compose
(#2488) via Jaewoong Eum (@skydoves)
* Improve Composable stabilities (#2478) via Jaewoong Eum (@skydoves)
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2486) via RevenueCat Git Bot (@RCGitBot)
* BC8 migration (#2477) via Toni Rico (@tonidero)
* Fixes building sample apps with SNAPSHOT dependencies (#2483) via
JayShortway (@JayShortway)
* [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule
(#2484) via RevenueCat Git Bot (@RCGitBot)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
@tonidero tonidero mentioned this pull request Jul 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2025
This reverts commit 34c61a3.

### Description
Reapplies the changes originally from #2477 that were reverted in #2501
to allow making a release in the current major.

Migrates to BC8:
https://developer.android.com/google/play/billing/release-notes#8-0-0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants