Fixes building sample apps with SNAPSHOT dependencies #2483
Conversation
…al Portal publishing.
| @@ -11,7 +10,9 @@ dependencyResolutionManagement { | |||
| repositories { | |||
| google() | |||
| mavenCentral() | |||
| maven(url = "https://oss.sonatype.org/content/repositories/snapshots") | |||
| maven(url = "https://central.sonatype.com/repository/maven-snapshots/") { | |||
There was a problem hiding this comment.
Hmm I do wonder if we need the snapshots repos in these apps... But I guess I'm ok leaving them in case we want to make use of one of our own snapshots... (I would probably point to mavenLocal in that case 😅 )
There was a problem hiding this comment.
True, but our automations are currently setting the dependency versions to snapshots in these apps, e.g. see libs.versions.toml of the CustomEntitlementComputationSample.
There was a problem hiding this comment.
Ahh you're right 🤦 Then yeah, we need it. Thanks for letting me know!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2483 +/- ##
=======================================
Coverage 78.72% 78.72%
=======================================
Files 289 289
Lines 10519 10519
Branches 1509 1509
=======================================
Hits 8281 8281
Misses 1590 1590
Partials 648 648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * feat(purchases): Add setPostHogUserId() method to Purchases API (#2495) via Hussain Mustafa (@hussain-mustafa990) ### 🐞 Bugfixes * Improves button progress indicator size calculation. (#2485) via JayShortway (@JayShortway) ### 🔄 Other Changes * Revert "BC8 migration (#2477)" (#2501) via Toni Rico (@tonidero) * Add codelab instructions on README file (#2489) via Jaewoong Eum (@skydoves) * Use collectAsStateWithLifecycle instead of collectAsState in Compose (#2488) via Jaewoong Eum (@skydoves) * Improve Composable stabilities (#2478) via Jaewoong Eum (@skydoves) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2486) via RevenueCat Git Bot (@RCGitBot) * BC8 migration (#2477) via Toni Rico (@tonidero) * Fixes building sample apps with SNAPSHOT dependencies (#2483) via JayShortway (@JayShortway) * [AUTOMATIC][Paywalls V2] Updates paywall-preview-resources submodule (#2484) via RevenueCat Git Bot (@RCGitBot) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Description
The SNAPSHOT repo URL has changed, now that we migrated to Central Portal publishing. I also removed it from plugin repos, as we don't use SNAPSHOT plugins, and removed
gradlePluginPortal()from depencency repos, as no dependencies are published there.This should fix the following failing CI jobs: