Skip to content

tests: introduce dedicated gnrc_rpl_srh test #10392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2019
Merged

tests: introduce dedicated gnrc_rpl_srh test #10392

merged 3 commits into from
Jan 11, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 14, 2018 •
edited
Loading

Contribution description

This introduces a dedicated test application for GNRC's RPL source router header implementation. It utilizes scapy for the generation of the routing headers. It also moves the unittests from the unittests application into this application.

Testing procedure

Compile tests/gnrc_rpl_srh and flash it to a board of your choice. Use sudo make test to run (due to the required Ethernet frame construction with the tap interface you need root permissions). The tests might hang and fail due to scapy's sniffer sometimes not picking up the expected packet. Maybe someone can help me with syncing the main thread and the sniffer thread of the python script here?

Issues/PRs references

Depends on #10242, #10244, and #10300(merged) and their dependencies:

PR dependencies

Addresses #8941 partly.

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking Area: tests Area: tests and testing framework labels Nov 14, 2018
@miri64 miri64 requested a review from cgundogan November 14, 2018 17:10
@miri64 miri64 mentioned this pull request Nov 14, 2018
Merged
3 tasks
@miri64 miri64 added State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 14, 2018
@miri64 miri64 changed the title tests/gnrc_rpl_srh: introduce dedicated gnrc_rpl_srh test tests: introduce dedicated gnrc_rpl_srh test Nov 14, 2018
@RIOT-OS RIOT-OS deleted a comment Nov 15, 2018
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 16, 2018
@miri64 miri64 mentioned this pull request Nov 17, 2018
Merged
@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from 99b638c to dc7012b Compare November 17, 2018 16:21
@miri64
Copy link
Member Author

miri64 commented Nov 17, 2018

Rebased to current dependencies

@RIOT-OS RIOT-OS deleted a comment Nov 17, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 19, 2018
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
c2ea8c0 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 19, 2018
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
26791d1 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
@miri64 miri64 mentioned this pull request Nov 19, 2018
Merged
@RIOT-OS RIOT-OS deleted a comment Nov 21, 2018
@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from 876871d to 799d943 Compare November 23, 2018 13:50
@miri64
Copy link
Member Author

miri64 commented Nov 23, 2018

Rebased to current master and dependencies.

@RIOT-OS RIOT-OS deleted a comment Nov 23, 2018
@RIOT-OS RIOT-OS deleted a comment Dec 9, 2018
@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from 8d08640 to aea29a3 Compare December 11, 2018 12:36
@miri64
Copy link
Member Author

miri64 commented Dec 11, 2018

Rebased to and tested for current master and dependencies.

@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from aea29a3 to 596a136 Compare December 14, 2018 11:06
@miri64
Copy link
Member Author

miri64 commented Dec 14, 2018

Rebased to current master and dependencies.

@RIOT-OS RIOT-OS deleted a comment Dec 15, 2018
@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from 596a136 to 0a72b98 Compare December 17, 2018 09:45
@miri64
Copy link
Member Author

miri64 commented Dec 17, 2018

Rebased to current master and dependencies.

@RIOT-OS RIOT-OS deleted a comment Dec 18, 2018
@jia200x jia200x added the Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines label Jan 11, 2019
@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

@miri64 could you squash?

@miri64 miri64 force-pushed the tests/new/gnrc_rpl_srh branch from 4201f3d to 3ff2edf Compare January 11, 2019 14:20
@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Squashed

@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Murdock and Travis are happy.

jia200x
jia200x approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

So this completes the GNRC IPv6 refactor. Congratz 🎉

GO

@jia200x jia200x merged commit 5b350d6 into RIOT-OS:master Jan 11, 2019
@miri64 miri64 deleted the tests/new/gnrc_rpl_srh branch January 11, 2019 14:44
@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Thank you @jia200x for all the review work for this project!

@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

no problem! thanks for all the work :)

@aabadie aabadie added this to the Release 2019.01 milestone Jan 13, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 22, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
ac50244 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
47992d6 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
acb2380 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
a6594c5 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
4b5b5d9 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 1, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
b8c2a9f 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 4, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
bd237b2 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 4, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
260fd58 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 5, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
5cecef8 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 5, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
e4146cd 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 19, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
d21364e 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
JulianHolzwarth pushed a commit to JulianHolzwarth/RIOT that referenced this pull request Feb 27, 2019
@miri64 @JulianHolzwarth
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
17d628a 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
TomKeddie pushed a commit to TomKeddie/RIOT that referenced this pull request Mar 4, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
32190cc 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
geromueller pushed a commit to geromueller/RIOT that referenced this pull request Jun 19, 2019
@miri64 @geromueller
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
9caa112 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
@miri64 miri64 mentioned this pull request Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@cgundogan cgundogan Awaiting requested review from cgundogan

Assignees
No one assigned
Labels
Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @jia200x @aabadie