Skip to content

tests/gnrc_ipv6_ext: port to scapy #10382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2019
Merged

tests/gnrc_ipv6_ext: port to scapy #10382

merged 1 commit into from
Jan 11, 2019

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Nov 13, 2018 •
edited
Loading

Contribution description

This ports the tests/gnrc_ipv6_ext (which are actually very simple tests for gnrc_rpl_ext), to just test the extension header parser using scapy to generate the IPv6 packets containing the extension headers.

TODOs:

  • Test IPv6 extension header parsing
    • Add readme
    • Update BOARD_INSUFFICIENT_MEMORY

Testing procedure

Compile tests/gnrc_ipv6_ext and flash it to a board of your choice. Use sudo make test to run (due to the required Ethernet frame construction with the tap interface you need root permissions).

Issues/PRs references

Depends on #8594, #10242, and #10244 and their dependencies:

PR dependencies

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Area: tests Area: tests and testing framework State: waiting for other PR State: The PR requires another PR to be merged first labels Nov 13, 2018
@miri64 miri64 requested a review from bergzand November 13, 2018 16:07
@miri64 miri64 mentioned this pull request Nov 13, 2018
Merged
@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch 2 times, most recently from ec1cafd to b262989 Compare November 13, 2018 23:30
@RIOT-OS RIOT-OS deleted a comment Nov 14, 2018
@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch from 4e559a6 to f1ad649 Compare November 14, 2018 07:51
@RIOT-OS RIOT-OS deleted a comment Nov 14, 2018
@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch from f1ad649 to c15cecb Compare November 14, 2018 17:14
@miri64 miri64 changed the title tests/gnrc_ipv6_ext: port to scapy [WIP] tests/gnrc_ipv6_ext: port to scapy Nov 14, 2018
@miri64 miri64 removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Nov 14, 2018
@miri64
Copy link
Member Author

miri64 commented Nov 14, 2018

Rebased to current dependencies, finished up the work and moved the RPL SRH tests to #10392. No longer WIP.

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 14, 2018
@RIOT-OS RIOT-OS deleted a comment Nov 15, 2018
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 16, 2018
@RIOT-OS RIOT-OS deleted a comment Nov 17, 2018
@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch from 4289710 to a153b45 Compare November 17, 2018 16:11
@miri64
Copy link
Member Author

miri64 commented Nov 17, 2018

Rebased to current dependencies and also applied some fixes for Arch.

@RIOT-OS RIOT-OS deleted a comment Nov 17, 2018
@RIOT-OS RIOT-OS deleted a comment Nov 17, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 19, 2018
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
c2ea8c0 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Nov 19, 2018
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
26791d1 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
@miri64 miri64 mentioned this pull request Nov 19, 2018
Merged
@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch from 0244b71 to 029d96a Compare November 22, 2018 12:46
@miri64
Copy link
Member Author

miri64 commented Nov 22, 2018

Rebased to current master and dependencies.

@RIOT-OS RIOT-OS deleted a comment Nov 22, 2018
@jia200x jia200x added the Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines label Jan 11, 2019
@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

Tested on samr21-xpro and native

@jia200x jia200x added Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jan 11, 2019
@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

@miri64 could you squash?

@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

(Codacy output can be ignored)

@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Squashed

@miri64 miri64 force-pushed the tests/enh/gnrc_ipv6_ext_scapy branch from 874fb3f to 70c9706 Compare January 11, 2019 12:27
@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Squashed

jia200x
jia200x approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@jia200x jia200x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@jia200x
Copy link
Member

jia200x commented Jan 11, 2019

Thank you! Just one more to go ;)

@jia200x jia200x merged commit bb095e4 into RIOT-OS:master Jan 11, 2019
@miri64
Copy link
Member Author

miri64 commented Jan 11, 2019

Thanks for the review! :-)

@miri64 miri64 deleted the tests/enh/gnrc_ipv6_ext_scapy branch January 11, 2019 12:52
@aabadie aabadie added this to the Release 2019.01 milestone Jan 13, 2019
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 22, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
ac50244 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
47992d6 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
acb2380 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
a6594c5 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
miri64 added a commit to miri64/RIOT that referenced this pull request Jan 29, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
4b5b5d9 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 1, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
b8c2a9f 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 4, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
bd237b2 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 4, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
260fd58 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 5, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
5cecef8 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 5, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
e4146cd 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
cladmi pushed a commit to cladmi/RIOT that referenced this pull request Feb 19, 2019
@miri64 @cladmi
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
d21364e 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
JulianHolzwarth pushed a commit to JulianHolzwarth/RIOT that referenced this pull request Feb 27, 2019
@miri64 @JulianHolzwarth
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
17d628a 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
TomKeddie pushed a commit to TomKeddie/RIOT that referenced this pull request Mar 4, 2019
@miri64
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
32190cc 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
geromueller pushed a commit to geromueller/RIOT that referenced this pull request Jun 19, 2019
@miri64 @geromueller
dist/pythonlibs: provide unittest TestCase wrapper for testrunner
9caa112 
I had this idea when implementing RIOT-OS#10382 and RIOT-OS#10392 as I introduced a
very similar structure to python's standard unittests in those and it
could also reduce some code duplication between those two tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia200x jia200x jia200x approved these changes

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: network Area: Networking Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.01
Development

Successfully merging this pull request may close these issues.
3 participants
@miri64 @jia200x @aabadie