tests/gcoap_dns: Remove duplicate #19154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
bors cancel |
|
Canceled. |
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
18863: boards/esp32s2-mini: add definition for ESP32 S2 Mini r=miri64 a=benpicco 18934: shell/gnrc_icmpv6_echo: separate ICMPv6 echo sending / parsing from shell command r=miri64 a=benpicco 19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
18934: shell/gnrc_icmpv6_echo: separate ICMPv6 echo sending / parsing from shell command r=miri64 a=benpicco 19060: SUBSYSTEMS.md: migrate subsystem list from wiki r=maribu a=jia200x 19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Jose Alamos <jose@alamos.cc> Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
This PR was included in a batch that was canceled, it will be automatically retried |
bors bot
added a commit
that referenced
this pull request
Jan 16, 2023
18934: shell/gnrc_icmpv6_echo: separate ICMPv6 echo sending / parsing from shell command r=maribu a=benpicco 19060: SUBSYSTEMS.md: migrate subsystem list from wiki r=maribu a=jia200x 19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Jose Alamos <jose@alamos.cc> Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed.
Further insights can be provided by @miri64