SUBSYSTEMS.md: migrate subsystem list from wiki #19060
Conversation
SUBSYSTEMS.md
Outdated
| - Thomas Eichinger [@thomaseichinger](https://github.com/thomaseichinger) | ||
| - Nick van IJzenoorn [@DipSwitch](https://github.com/DipSwitch) |
There was a problem hiding this comment.
Please don't just 'migrate' over inactive maintainers, start from scratch and let active maintainers fill in what they feel responsible for.
If we 'assign' people this will have to value, they have to actively feel responsible for their subsystem.
There was a problem hiding this comment.
I kind of created the subsystems from scratch but migrated some of the maintainers. Should I just drop them all and let them add themselves?
There was a problem hiding this comment.
That sounds like a good idea. Let's also merge this without maintainers in it. We can distribute and parallize the work the better once the file is merged. (I fear otherwise there will be an endless discussion on nitpicking who to add and who not.)
There was a problem hiding this comment.
Yes, we don't want the situation where people are like "Oh, I don't know why I'm on that list, I don't feel responsible for that subsystem".
There should be some commitment that can be expressed by actively editing the list.
I think we can also push to your branch directly.
There was a problem hiding this comment.
done! I just removed all maintainers from the list. We can merge this one and then ask maintainers to add themselves to the list, as proposed above.
51253ba to
8f8266d
Compare
18934: shell/gnrc_icmpv6_echo: separate ICMPv6 echo sending / parsing from shell command r=miri64 a=benpicco 19060: SUBSYSTEMS.md: migrate subsystem list from wiki r=maribu a=jia200x 19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Jose Alamos <jose@alamos.cc> Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
This PR was included in a batch that was canceled, it will be automatically retried |
18934: shell/gnrc_icmpv6_echo: separate ICMPv6 echo sending / parsing from shell command r=maribu a=benpicco 19060: SUBSYSTEMS.md: migrate subsystem list from wiki r=maribu a=jia200x 19154: tests/gcoap_dns: Remove duplicate r=miri64 a=Teufelchen1 ### Contribution description Removes a duplicated test. Originally, the test should have looked different and not be a duplicate. However, the behavior the test aimed at is no longer present anyway, hence it can be removed - rather than fixed. Further insights can be provided by `@miri64` Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de> Co-authored-by: Jose Alamos <jose@alamos.cc> Co-authored-by: Teufelchen1 <bennet.blischke@haw-hamburg.de>
|
Build failed (retrying...): |
|
Build succeeded: |
Contribution description
This PR migrate the existing list of subsystems to the RIOT repo.
I also updated the list to represent the actual state of the system.
The list is definitely not perfect and may need several iterations. Feel free to add commits on demand.
We should definitely add more descriptions though, at least for the top headings (CPU, Core, etc).
The original entry included boards as well, but IMO it doesn't really make sense, as they are not a subsystem.
Testing procedure
Read. Make sure that the list makes sense.
Issues/PRs references
Discussed during the Virtual Maintainer Assembly