-
Notifications
You must be signed in to change notification settings - Fork 191
Adding Fuzz targets for random graph generator #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Fuzz targets for random graph generator #1430
Conversation
Added a fuzz target for random graph generator with max edges.
Pull Request Test Coverage Report for Build 14514959540Details
💛 - Coveralls |
input.seed, | ||
|| (), | ||
|| (), | ||
) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other interesting check that we can have is that calling the method twice with the same seed generates that same graph i.e. the nodes and edges are all the same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that sounds like a good idea, I'll add and push that test too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just leaving the comment to have a check where we call gnm_random_graph
with the same seed and assert it is the same graph.
Hopefully that it is the current behavior. If it fails, let me know
Added another test to check determinism (if same graph is returned for the same seed).
Thanks for fixing the linting issues, I will merge now |
* Adding Fuzz targets for random graph generator Added a fuzz target for random graph generator with max edges. * Updates based on comments Added another test to check determinism (if same graph is returned for the same seed). * fixing lint issues * Removing unused imports --------- Co-authored-by: Ivan Carvalho <8753214+IvanIsCoding@users.noreply.github.com>
Added a fuzz target for random graph generator with max edges.