Hi @IvanIsCoding, I have made the required changes. Let me know if there is anything else.

There are some cargo clippy failures, you can see them on CI or run the command locally like I’m CONTRIBUTING.md.

You’ll need to fix the lint findings first before I can merge

We got one test failure on CI:

failures:

---- rustworkx-core/src/generators/random_graph.rs - generators::random_graph::random_regular_graph (line 68) stdout ----
Test executable failed (exit status: 101).

stderr:

thread 'main' panicked at rustworkx-core/src/generators/random_graph.rs:16:1:
assertion `left == right` failed
  left: 4
 right: 2
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace



failures:
    rustworkx-core/src/generators/random_graph.rs - generators::random_graph::random_regular_graph (line 68)

test result: FAILED. 85 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 9.93s

You'll need to investigate the bug. I will also try to found out why

So there were two mistakes:

• For n=4, d=2, we expect there to be 4 edges. ((n*d)/2 is the number of edges)
• The algorithms sometimes generates 4 edges, sometimes it doesn't. For the seed 2025, it looks like it doesn't. So I fixed the seed and let's focus on making it pass

Oh sorry, forgot to fix the number of edges generated in the doctest place. However, the particular error post that arises due to a bug. We switched from

*potential_edges.entry(u).or_insert(0) += 1;
*potential_edges.entry(v).or_insert(0) += 1;

to

*potential_edges.entry(u).or_insert(1);
*potential_edges.entry(v).or_insert(1);

this led to some of the edges being ignored, so I am reverting this back and will see if this help pass the tests

Indeed, I introduced a bug with that comment. It turns out that the .contains() was a check in another hashmap... Well, I think it should be good to go now.

I am also happy the tests caught it.

Pull Request Test Coverage Report for Build 14420374667

Details

• 0 of 96 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.5%) to 95.369%

Totals
Change from base Build 14391902387:	-0.5%
Covered Lines:	18637
Relevant Lines:	19542

💛 - Coveralls