Skip to content

Use PyGenericAlias from PyO3 instead of importing types.GenericAlias #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 7, 2025
Merged

Use PyGenericAlias from PyO3 instead of importing types.GenericAlias #1421

merged 2 commits into from
Apr 7, 2025

Conversation

IvanIsCoding
Copy link
Collaborator

Follow up of #1348

Since #1415, we have PyO3 0.24 that contains PyO3/pyo3#4917 which will make __clas_geitem__ slightly simpler and faster

@IvanIsCoding IvanIsCoding requested a review from mtreinish April 6, 2025 22:10
@coveralls
Copy link

coveralls commented Apr 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14309377437

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 95.337%
Totals Coverage Status
Change from base Build 14309295835: -0.003%
Covered Lines: 18505
Relevant Lines: 19410
💛 - Coveralls

mtreinish
mtreinish approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, it's cool to see the interface you added for this got included in the new release and we're able to use it here so neatly.

@mtreinish mtreinish added this pull request to the merge queue Apr 7, 2025
Merged via the queue into Qiskit:main with commit 6ffa9bd Apr 7, 2025
31 checks passed
@IvanIsCoding IvanIsCoding mentioned this pull request Apr 13, 2025
Merged
6 tasks
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
@IvanIsCoding @SILIZ4
Use PyGenericAlias directly from PyO3 (Qiskit#1421)
dffd0a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IvanIsCoding @coveralls @mtreinish