Use BFS to compute shortest paths in Closeness Centrality #1426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14421343930Details
💛 - Coveralls |
mtreinish
approved these changes
Apr 17, 2025
Comment on lines
+1143
to
+1144
| for edge in g.edges(node) { | ||
| let target = edge.target(); |
There was a problem hiding this comment.
I was thinking we could do for target in g.neighbors_directed(node, Outgoing) here, but that would require we add the trait bound IntoNeighborsDirected on G and that seems unnecessary so this is fine.
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1392
This is nothing too complex, but just like in #593 we missed the parallelization, we also missed that the shortest path function could be a faster one.