Add parallelism to cloness_centrality
#1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14346065276Details
💛 - Coveralls |
|
Because #1387, I added a test to boost the coverage in the report. I am confident the Rust tests guarantee the correctness so for now that is a stop gap |
mtreinish
reviewed
Mar 15, 2025
mtreinish
reviewed
Apr 7, 2025
releasenotes/notes/parallel-closeness-centrality-5165f62e370181eb.yaml
Outdated
Show resolved
Hide resolved
mtreinish
reviewed
Apr 8, 2025
|
Let me update the Python docs and fix the formatting |
mtreinish
approved these changes
Apr 9, 2025
SILIZ4
pushed a commit
to SILIZ4/rustworkx
that referenced
this pull request
Jul 4, 2025
* First look at parallel implementation * Add parallel threshold parameter * Add parllel_threshold to Python arguments * Make weighted closeness centrality also parallel * Add new argument to type stubs * Document parameters for newman's type specific functions * Add parallel tests to Python * Add release notes for the change * Boost coverage of Newman Weighted Centrality via unweighted test case * Simplify implementation with .collect() * Add parallel_threshold to docstring * Fix cargo clippy warnings * Document RAYON_NUM_THREADS * Move reno section to upgrade * Add rayon num threads detail to Python * Update Python docstring as well * Try to fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
closeness_centralityandnewman_weighted_closeness_centralityparallel for better performance. This is possible because the task is embarrassingly parallel.We probably missed this in #593 but #1385 reminded me of it.
The parallelism is toggled via the
parallel_thresholdjust like other centrality methods.